All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: mark.einon@gmail.com
Cc: Thomas Fourier <fourier.thomas@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] et131x: Add missing check after DMA map
Date: Wed, 16 Jul 2025 19:53:55 +0100	[thread overview]
Message-ID: <20250716185355.GQ721198@horms.kernel.org> (raw)
In-Reply-To: <9ba42e9ae61e8274bf5d677f8d53c84f6841ccd8.camel@gmail.com>

On Wed, Jul 16, 2025 at 12:19:50PM +0100, mark.einon@gmail.com wrote:
> On Wed, 2025-07-16 at 11:47 +0200, Thomas Fourier wrote:
> > The DMA map functions can fail and should be tested for errors.
> > If the mapping fails, unmap and return an error.
> > 
> > Fixes: 38df6492eb51 ("et131x: Add PCIe gigabit ethernet driver et131x
> > to drivers/net")
> > Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> > ---
> > v1 -> v2:
> >   - Fix subject
> >   - Fix double decrement of frag
> >   - Make comment more explicit about why there are two loops
> 
> Thanks for the updates Thomas, LGTM (also CC'd Simon who provided the
> initial comments).
> 
> Acked-by: Mark Einon <mark.einon@gmail.com>

Thanks, also LGTM.

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2025-07-16 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16  9:47 [PATCH net v2] et131x: Add missing check after DMA map Thomas Fourier
2025-07-16 11:19 ` mark.einon
2025-07-16 18:53   ` Simon Horman [this message]
2025-07-18  2:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716185355.GQ721198@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fourier.thomas@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.einon@gmail.com \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.