All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: aubrey.li@linux.intel.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [anolis-intel-cloud:devel-5.10 6/6] mm/memory_hotplug.c:664:12: warning: no previous prototype for function '__move_pfn_range_to_zone'
Date: Wed, 16 Jul 2025 20:55:17 +0800	[thread overview]
Message-ID: <202507162044.llc5U1lr-lkp@intel.com> (raw)

tree:   https://gitee.com/anolis/intel-cloud-kernel.git devel-5.10
head:   1535649a0387dabbc4baec56dbc329c3046d3ad1
commit: 6c4a83f3c62b8ef3f8bd1ec3c1d374bf0e12713d [6/6] anolis: mm/memory_hotplug: refactor move_pfn_range_to_zone()
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250716/202507162044.llc5U1lr-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 16534d19bf50bde879a83f0ae62875e2c5120e64)
rustc: rustc 1.58.0 (02072b482 2022-01-11)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250716/202507162044.llc5U1lr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507162044.llc5U1lr-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/memory_hotplug.c:664:12: warning: no previous prototype for function '__move_pfn_range_to_zone' [-Wmissing-prototypes]
     664 | void __ref __move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn,
         |            ^
   mm/memory_hotplug.c:664:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     664 | void __ref __move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn,
         | ^
         | static 
   mm/memory_hotplug.c:995:6: warning: no previous prototype for function '__adjust_present_page_count' [-Wmissing-prototypes]
     995 | void __adjust_present_page_count(struct page *page, struct memory_group *group,
         |      ^
   mm/memory_hotplug.c:995:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     995 | void __adjust_present_page_count(struct page *page, struct memory_group *group,
         | ^
         | static 
   2 warnings generated.


vim +/__move_pfn_range_to_zone +664 mm/memory_hotplug.c

   663	
 > 664	void __ref __move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn,
   665					  unsigned long nr_pages, struct vmem_altmap *altmap,
   666					  int migratetype, int phase)
   667	{
   668		struct pglist_data *pgdat = zone->zone_pgdat;
   669		int nid = pgdat->node_id;
   670		unsigned long flags;
   671	
   672		if (phase == MHP_PHASE_DEFAULT || phase == MHP_PHASE_PREPARE) {
   673	#ifdef KIDLED_AGE_NOT_IN_PAGE_FLAGS
   674			kidled_free_page_age(pgdat);
   675	#endif
   676			clear_zone_contiguous(zone);
   677	
   678			/* TODO Huh pgdat is irqsave while zone is not. It used to be like that before */
   679			pgdat_resize_lock(pgdat, &flags);
   680			zone_span_writelock(zone);
   681			if (zone_is_empty(zone))
   682				init_currently_empty_zone(zone, start_pfn, nr_pages);
   683			resize_zone_range(zone, start_pfn, nr_pages);
   684			zone_span_writeunlock(zone);
   685			resize_pgdat_range(pgdat, start_pfn, nr_pages);
   686			pgdat_resize_unlock(pgdat, &flags);
   687		}
   688	
   689		/*
   690		 * TODO now we have a visible range of pages which are not associated
   691		 * with their zone properly. Not nice but set_pfnblock_flags_mask
   692		 * expects the zone spans the pfn range. All the pages in the range
   693		 * are reserved so nobody should be touching them so we should be safe
   694		 */
   695		if (phase == MHP_PHASE_DEFAULT || phase == MHP_PHASE_DEFERRED)
   696			memmap_init_zone(nr_pages, nid, zone_idx(zone), start_pfn, 0,
   697				 MEMINIT_HOTPLUG, altmap, migratetype);
   698	
   699		if (phase == MHP_PHASE_DEFAULT || phase == MHP_PHASE_PREPARE)
   700			set_zone_contiguous(zone);
   701	}
   702	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-07-16 12:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202507162044.llc5U1lr-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.