From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8ECDC83F1B for ; Wed, 16 Jul 2025 11:16:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AD4810E060; Wed, 16 Jul 2025 11:16:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="k4QENnLP"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1130610E060 for ; Wed, 16 Jul 2025 11:16:44 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 520FCA56F61; Wed, 16 Jul 2025 11:16:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83928C4CEF0; Wed, 16 Jul 2025 11:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752664603; bh=TG1acE7nMtWtoIam9461xYKie1pDhX6BPiukuv2rb/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k4QENnLPhqXVfpjP833WnLbGbHXwioMwf6DqZnFECNZ9SM+s3+qPHAxxaPP1bplpy xJH1usHzHrKZ9eRBGwnfLvxdBkyq1VjCHbmrKcULM2d8fJJW3wDkIMKN1DkrkvabSS Qle5j/bvjvieA30BwgTU/Nq/fQKQs/5Q4NpRzDRE= Date: Wed, 16 Jul 2025 13:16:40 +0200 From: Greg Kroah-Hartman To: phasta@kernel.org Cc: Michel =?iso-8859-1?Q?D=E4nzer?= , "cao, lin" , "dri-devel@lists.freedesktop.org" , "Yin, ZhenGuo (Chris)" , "Deng, Emily" , "Koenig, Christian" , "dakr@kernel.org" , "matthew.brost@intel.com" , Sasha Levin Subject: Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs Message-ID: <2025071623-sleeve-flip-3836@gregkh> References: <20250715135033.706126-1-lincao12@amd.com> <49d822fc0f46e0fdeaccaeb2fbb1ade1c5cb1e5d.camel@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49d822fc0f46e0fdeaccaeb2fbb1ade1c5cb1e5d.camel@mailbox.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 16, 2025 at 12:46:21PM +0200, Philipp Stanner wrote: > +Cc Greg, Sasha > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: > > On 16.07.25 11:57, Philipp Stanner wrote: > > > On Wed, 2025-07-16 at 09:43 +0000, cao, lin wrote: > > > > > > > > Hi Philipp, > > > > > > > > > > > > Thank you for the review. I found that this optimization was > > > > introduced 9 years ago in commit > > > > 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a > > > > dummy > > > > wakeup scheduler"). > > > > > > > > > > > > Given that the codebase has undergone significant changes over > > > > these > > > > 9 years. May I ask if I still need to include the Fixes: tag? > > > > > > Yes. It's a helpful marker to see where the problem comes from, and > > > it > > > adds redundancy helping the stable-kernel maintainers in figuring > > > out > > > to which kernels to backport it to. > > > > > > If stable can't apply a patch to a very old stable kernel because > > > the > > > code base changed too much, they'll ping us and we might provide a > > > dedicated fix. > > > > > > So like that: > > > > > > Cc: stable@vger.kernel.org # v4.6+ > > > Fixes: 777dbd458c89 ("drm/amdgpu: drop a dummy wakeup scheduler") > > > > FWIW, Fixes: alone is enough for getting backported to stable > > branches, Cc: stable is redundant with it. As stated later in this thread, this is NOT TRUE AT ALL. Always explicitly tag things for stable with "cc: stable" for stuff you want to go to the stable trees. If you only use "Fixes:" there is no such guarantee at all. That goes doubly for the drm trees, where we have a hard enough time applying the cc: stable@ patches that you all double-commit to different branches, and we dread every time we see it happen... thanks, greg k-h