From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] kconfig: gconf: fix single view to display dependent symbols correctly
Date: Thu, 17 Jul 2025 08:24:08 +0900 [thread overview]
Message-ID: <20250716232542.873747-1-masahiroy@kernel.org> (raw)
In the following example, the symbol C was never displayed in Single
view. Fix the recursion logic so that all symbols are shown.
menu "menu"
config A
bool "A"
config B
bool "B"
depends on A
config C
bool "C"
depends on B
endmenu
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/gconf.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 7725d2c9d92a..c67b35807e8e 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -914,9 +914,7 @@ static gboolean on_treeview1_button_press_event(GtkWidget *widget,
static void _display_tree(GtkTreeStore *tree, struct menu *menu,
GtkTreeIter *parent)
{
- struct property *prop;
struct menu *child;
- enum prop_type ptype;
GtkTreeIter iter;
for (child = menu->list; child; child = child->next) {
@@ -929,9 +927,6 @@ static void _display_tree(GtkTreeStore *tree, struct menu *menu,
if (child->type == M_IF)
continue;
- prop = child->prompt;
- ptype = prop ? prop->type : P_UNKNOWN;
-
if ((view_mode == SPLIT_VIEW)
&& !(child->flags & MENU_ROOT) && (tree == tree1))
continue;
@@ -943,16 +938,7 @@ static void _display_tree(GtkTreeStore *tree, struct menu *menu,
gtk_tree_store_append(tree, &iter, parent);
set_node(tree, &iter, child);
- if ((view_mode == SINGLE_VIEW) && (ptype == P_MENU))
- continue;
-/*
- if (((menu != &rootmenu) && !(menu->flags & MENU_ROOT))
- || (view_mode == FULL_VIEW)
- || (view_mode == SPLIT_VIEW))*/
-
- if (((view_mode == SINGLE_VIEW) && (menu->flags & MENU_ROOT))
- || (view_mode == FULL_VIEW)
- || (view_mode == SPLIT_VIEW))
+ if (view_mode != SINGLE_VIEW || child->type != M_MENU)
_display_tree(tree, child, &iter);
}
}
--
2.43.0
next reply other threads:[~2025-07-16 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 23:24 Masahiro Yamada [this message]
2025-07-16 23:24 ` [PATCH 2/6] kconfig: gconf: Fix Back button behavior Masahiro Yamada
2025-07-16 23:24 ` [PATCH 3/6] kconfig: gconf: replace GtkImageMenuItem with GtkMenuItem Masahiro Yamada
2025-07-16 23:24 ` [PATCH 4/6] kconfig: gconf: use hyphens in signals Masahiro Yamada
2025-07-16 23:24 ` [PATCH 5/6] kconfig: gconf: remove unneeded variable in text_insert_msg Masahiro Yamada
2025-07-16 23:24 ` [PATCH 6/6] kconfig: gconf: refactor text_insert_help() Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716232542.873747-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.