All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	Jeff Hugo <jeff.hugo@oss.qualcomm.com>,
	Youssef Samir <quic_yabdulra@quicinc.com>,
	Matthew Leung <quic_mattleun@quicinc.com>,
	Alexander Wilhelm <alexander.wilhelm@westermo.com>,
	Kunwu Chan <chentao@kylinos.cn>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
	Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
	Yan Zhen <yanzhen@vivo.com>, Sujeev Dias <sdias@codeaurora.org>,
	Siddartha Mohanadoss <smohanad@codeaurora.org>,
	mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] bus: mhi: host: keep bhie buffer through suspend cycle
Date: Wed, 16 Jul 2025 11:35:14 +0200	[thread overview]
Message-ID: <2025071651-rake-rake-7a13@gregkh> (raw)
In-Reply-To: <20250715132509.2643305-3-usama.anjum@collabora.com>

On Tue, Jul 15, 2025 at 06:25:08PM +0500, Muhammad Usama Anjum wrote:
> When there is memory pressure, at resume time dma_alloc_coherent()
> returns error which in turn fails the loading of the firmware and hence
> the driver crashes.
> 
> Fix it by allocating only once and then reuse the same allocated memory.
> As we'll allocate this memory only once, this memory will stays
> allocated.

Again, no, do not waste memory like this.  If all drivers/devices did
this that would be horrible.

greg k-h

  reply	other threads:[~2025-07-16  9:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 13:25 [PATCH v2 0/3] bus: mhi: keep dma buffers through suspend/hibernation cycles Muhammad Usama Anjum
2025-07-15 13:25 ` [PATCH v2 1/3] bus: mhi: host: keep bhi buffer through suspend cycle Muhammad Usama Anjum
2025-07-16  3:41   ` Baochen Qiang
2025-07-16  9:34   ` Greg Kroah-Hartman
2025-07-17 10:00     ` Muhammad Usama Anjum
2025-07-17 11:50       ` Greg Kroah-Hartman
2025-07-15 13:25 ` [PATCH v2 2/3] bus: mhi: host: keep bhie " Muhammad Usama Anjum
2025-07-16  9:35   ` Greg Kroah-Hartman [this message]
2025-07-15 13:25 ` [PATCH v2 3/3] bus: mhi: keep device context through suspend cycles Muhammad Usama Anjum
2025-07-16  9:35   ` Greg Kroah-Hartman
2025-07-16  3:36 ` [PATCH v2 0/3] bus: mhi: keep dma buffers through suspend/hibernation cycles Baochen Qiang
2025-07-17 10:01   ` Muhammad Usama Anjum
  -- strict thread matches above, loose matches on Subject: below --
2025-07-21 13:20 [PATCH v2 2/3] bus: mhi: host: keep bhie buffer through suspend cycle kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025071651-rake-rake-7a13@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.wilhelm@westermo.com \
    --cc=chentao@kylinos.cn \
    --cc=jacek.lawrynowicz@linux.intel.com \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=kernel@collabora.com \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=quic_mattleun@quicinc.com \
    --cc=quic_yabdulra@quicinc.com \
    --cc=sdias@codeaurora.org \
    --cc=smohanad@codeaurora.org \
    --cc=stable@vger.kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=yanzhen@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.