From: Christoph Hellwig <hch@lst.de>
To: Yu Kuai <yukuai@kernel.org>
Cc: Coly Li <i@coly.li>, Christoph Hellwig <hch@lst.de>,
Coly Li <colyli@kernel.org>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
Yu Kuai <yukuai3@huawei.com>, Xiao Ni <xni@redhat.com>,
Hannes Reinecke <hare@suse.de>, Martin Wilck <mwilck@suse.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [RFC PATCH] md: split bio by io_opt size in md_submit_bio()
Date: Thu, 17 Jul 2025 06:52:10 +0200 [thread overview]
Message-ID: <20250717045210.GA27227@lst.de> (raw)
In-Reply-To: <284433c9-c11d-401f-8015-41faa9d0fde1@kernel.org>
On Thu, Jul 17, 2025 at 12:29:27AM +0800, Yu Kuai wrote:
>> If opt_io_size is (chunk_size * data_disks), setting new max_hw_sectors as rounddown(current max_hw_sectors, opt_io_size) is good idea.
>
> I think round down max_hw_sectors to io_opt(chunk_size * data_disks) will
> really
> make things much easier, perhaps Christoph means this way. All you need to
> do is to
> handle not aligned bio and split that part, and for aligned bio fall back
> to use
> bio_split_to_limits().
If the raid5 code can handle multiple stripes per I/O, than you
just need to round it down, yes. I assumed it could only handle
a single full or partial stripe at a time, but I guess I was wrong.
next prev parent reply other threads:[~2025-07-17 4:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:02 [RFC PATCH] md: split bio by io_opt size in md_submit_bio() colyli
2025-07-16 1:46 ` Yu Kuai
2025-07-16 6:58 ` Yu Kuai
2025-07-16 8:50 ` Coly Li
2025-07-16 9:30 ` Yu Kuai
2025-07-16 11:37 ` Christoph Hellwig
2025-07-16 11:39 ` Coly Li
2025-07-16 11:41 ` Christoph Hellwig
2025-07-16 11:44 ` Coly Li
2025-07-16 11:45 ` Christoph Hellwig
2025-07-16 12:10 ` Coly Li
2025-07-16 12:14 ` Christoph Hellwig
2025-07-16 12:16 ` Coly Li
2025-07-16 12:17 ` Christoph Hellwig
2025-07-16 12:23 ` Coly Li
2025-07-16 16:29 ` Yu Kuai
2025-07-17 4:52 ` Christoph Hellwig [this message]
2025-07-17 15:19 ` Coly Li
-- strict thread matches above, loose matches on Subject: below --
2025-07-15 17:59 colyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717045210.GA27227@lst.de \
--to=hch@lst.de \
--cc=colyli@kernel.org \
--cc=hare@suse.de \
--cc=i@coly.li \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=xni@redhat.com \
--cc=yukuai3@huawei.com \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.