All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: fw@strlen.de
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
	horms@kernel.org
Subject: Re: [PATCH net 2/7] selftests: netfilter: add conntrack clash resolution test case
Date: Thu, 17 Jul 2025 06:22:18 -0700	[thread overview]
Message-ID: <20250717062218.380dab89@kernel.org> (raw)
In-Reply-To: <20250717095122.32086-3-pablo@netfilter.org>

On Thu, 17 Jul 2025 11:51:17 +0200 Pablo Neira Ayuso wrote:
> Add a dedicated test to exercise conntrack clash resolution path.
> Test program emits 128 identical udp packets in parallel, then reads
> back replies from socat echo server.
> 
> Also check (via conntrack -S) that the clash path was hit at least once.
> Due to the racy nature of the test its possible that despite the
> threaded program all packets were processed in-order or on same cpu,
> emit a SKIP warning in this case.
> 
> Two tests are added:
>  - one to test the simpler, non-nat case
>  - one to exercise clash resolution where packets
>    might have different nat transformations attached to them.

This appears to fail for us:

TAP version 13
1..1
# timeout set to 1800
# selftests: net/netfilter: conntrack_clash.sh
# got 128 of 128 replies
# timed out while waiting for reply from thread
# got 127 of 128 replies
# FAIL: did not receive expected number of replies for 10.0.1.99:22111
# FAIL: clash resolution test for 10.0.1.99:22111 on attempt 2
# got 128 of 128 replies
# timed out while waiting for reply from thread
# got 0 of 128 replies
# FAIL: did not receive expected number of replies for 127.0.0.1:9001
# FAIL: clash resolution test for 127.0.0.1:9001 on attempt 2
# SKIP: Clash resolution did not trigger
not ok 1 selftests: net/netfilter: conntrack_clash.sh # exit=1
make[1]: Leaving directory '/home/virtme/testing-15/tools/testing/selftests/net/netfilter'
make: Leaving directory '/home/virtme/testing-15/tools/testing/selftests'

  reply	other threads:[~2025-07-17 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17  9:51 [PATCH net 0/7] Netfilter fixes for net Pablo Neira Ayuso
2025-07-17  9:51 ` [PATCH net 1/7] selftests: netfilter: conntrack_resize.sh: extend resize test Pablo Neira Ayuso
2025-07-17 13:00   ` patchwork-bot+netdevbpf
2025-07-17  9:51 ` [PATCH net 2/7] selftests: netfilter: add conntrack clash resolution test case Pablo Neira Ayuso
2025-07-17 13:22   ` Jakub Kicinski [this message]
2025-07-17 15:14     ` Florian Westphal
2025-07-17  9:51 ` [PATCH net 3/7] selftests: netfilter: conntrack_resize.sh: also use udpclash tool Pablo Neira Ayuso
2025-07-17  9:51 ` [PATCH net 4/7] selftests: netfilter: nft_concat_range.sh: send packets to empty set Pablo Neira Ayuso
2025-07-17  9:51 ` [PATCH net 5/7] netfilter: nf_tables: hide clash bit from userspace Pablo Neira Ayuso
2025-07-17  9:51 ` [PATCH net 6/7] Revert "netfilter: nf_tables: Add notifications for hook changes" Pablo Neira Ayuso
2025-07-17  9:51 ` [PATCH net 7/7] netfilter: nf_conntrack: fix crash due to removal of uninitialised entry Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250717062218.380dab89@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.