From: Jakub Kicinski <kuba@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: davem@davemloft.net, linux-bluetooth@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [GIT PULL] bluetooth 2025-07-17
Date: Thu, 17 Jul 2025 08:54:44 -0700 [thread overview]
Message-ID: <20250717085444.2847ac02@kernel.org> (raw)
In-Reply-To: <CABBYNZKW8aG=sJP+iwk44ozvJwiv0wPkrPrOBrnFZ=39rA7-CA@mail.gmail.com>
On Thu, 17 Jul 2025 11:47:49 -0400 Luiz Augusto von Dentz wrote:
> > On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:
> > > Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap
> >
> > FTR this rename and adding the helpers does not seem to be very
> > necessary for the fix? I know Greg says that we shouldn't intentionally
> > try to make fixes small, but there's a fine line between following that
> > and coincidental code refactoring.
>
> I should have reworded that commit, it is actually a fix, not just
> renaming, we run out of bits on a 32 bits system due to usage of int
> as storage.
Right, but I think if the new bitmap was called quirks the existing
set_bit / test_bit call sites would have been just fine, right?
The bit ops operate on single ulong and bitmaps all the same.
next prev parent reply other threads:[~2025-07-17 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 14:28 [GIT PULL] bluetooth 2025-07-17 Luiz Augusto von Dentz
2025-07-17 15:00 ` patchwork-bot+netdevbpf
2025-07-17 15:38 ` Jakub Kicinski
2025-07-17 15:47 ` Luiz Augusto von Dentz
2025-07-17 15:54 ` Jakub Kicinski [this message]
2025-07-17 16:42 ` Luiz Augusto von Dentz
2025-07-23 15:59 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717085444.2847ac02@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.