Re: [PATCH 00/11] NXP DPAA2 driver enhancements and fixes

[Stephen Hemminger <stephen@networkplumber.org>]

Too late for 25.07 now. But will put in next-net for 25.11

I notice if shadow declaration warning is enabled, lots of
warning occur.


In file included from ../drivers/net/dpaa2/dpaa2_ethdev.c:26:
../drivers/net/dpaa2/dpaa2_ethdev.c: In function ‘dpaa2_alloc_rx_tx_queues’:
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |             ^~~
../drivers/net/dpaa2/dpaa2_ethdev.c:393:23: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  393 |                 ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:16: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |                ^~~
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:22: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |                      ^
../drivers/net/dpaa2/dpaa2_ethdev.c:393:23: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  393 |                 ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |             ^~~
../drivers/net/dpaa2/dpaa2_ethdev.c:408:23: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  408 |                 ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:16: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |                ^~~
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:22: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |                      ^
../drivers/net/dpaa2/dpaa2_ethdev.c:408:23: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  408 |                 ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |             ^~~
../drivers/net/dpaa2/dpaa2_ethdev.c:435:31: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  435 |                         ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:16: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |                ^~~
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:207:22: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  207 |         int ret = 0, i; \
      |                      ^
../drivers/net/dpaa2/dpaa2_ethdev.c:435:31: note: in expansion of macro ‘dpaa2_queue_storage_alloc’
  435 |                         ret = dpaa2_queue_storage_alloc(dpaa2_q,
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:226:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  226 |         int i; \
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c:455:17: note: in expansion of macro ‘dpaa2_queue_storage_free’
  455 |                 dpaa2_queue_storage_free(dpaa2_q, RTE_MAX_LCORE);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:226:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  226 |         int i; \
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c:472:17: note: in expansion of macro ‘dpaa2_queue_storage_free’
  472 |                 dpaa2_queue_storage_free(dpaa2_q, RTE_MAX_LCORE);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:226:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  226 |         int i; \
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c:478:17: note: in expansion of macro ‘dpaa2_queue_storage_free’
  478 |                 dpaa2_queue_storage_free(dpaa2_q, RTE_MAX_LCORE);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:372:13: note: shadowed declaration is here
  372 |         int i, ret = 0;
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c: In function ‘dpaa2_free_rx_tx_queues’:
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:226:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  226 |         int i; \
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c:499:25: note: in expansion of macro ‘dpaa2_queue_storage_free’
  499 |                         dpaa2_queue_storage_free(dpaa2_q,
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:490:13: note: shadowed declaration is here
  490 |         int i;
      |             ^
../drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:226:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
  226 |         int i; \
      |             ^
../drivers/net/dpaa2/dpaa2_ethdev.c:511:33: note: in expansion of macro ‘dpaa2_queue_storage_free’
  511 |                                 dpaa2_queue_storage_free(dpaa2_q,
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa2/dpaa2_ethdev.c:490:13: note: shadowed declaration is here
  490 |         int i;
      |             ^
[50/168] Compiling C object drivers/li...net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o
../drivers/net/dpaa2/dpaa2_rxtx.c: In function ‘dpaa2_dev_tx’:
../drivers/net/dpaa2/dpaa2_rxtx.c:1393:37: warning: declaration of ‘ret’ shadows a previous local [-Wshadow]
 1393 |                                 int ret = rte_vlan_insert(bufs);
      |                                     ^~~
../drivers/net/dpaa2/dpaa2_rxtx.c:1250:17: note: shadowed declaration is here
 1250 |         int32_t ret;