From: Simon Horman <horms@kernel.org>
To: Daniel Zahka <daniel.zahka@gmail.com>
Cc: "Donald Hunter" <donald.hunter@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Boris Pismenny" <borisp@nvidia.com>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Willem de Bruijn" <willemb@google.com>,
"David Ahern" <dsahern@kernel.org>,
"Neal Cardwell" <ncardwell@google.com>,
"Patrisious Haddad" <phaddad@nvidia.com>,
"Raed Salem" <raeds@nvidia.com>,
"Jianbo Liu" <jianbol@nvidia.com>,
"Dragos Tatulea" <dtatulea@nvidia.com>,
"Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
"Jacob Keller" <jacob.e.keller@intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 00/19] add basic PSP encryption for TCP connections
Date: Thu, 17 Jul 2025 13:43:59 +0100 [thread overview]
Message-ID: <20250717124359.GF27043@horms.kernel.org> (raw)
In-Reply-To: <20250716144551.3646755-1-daniel.zahka@gmail.com>
On Wed, Jul 16, 2025 at 07:45:21AM -0700, Daniel Zahka wrote:
> This is v4 of the PSP RFC [1] posted by Jakub Kicinski one year
> ago. General developments since v1 include a fork of packetdrill [2]
> with support for PSP added, as well as some test cases, and an
> implementation of PSP key exchange and connection upgrade [3]
> integrated into the fbthrift RPC library. Both [2] and [3] have been
> tested on server platforms with PSP-capable CX7 NICs. Below is the
> cover letter from the original RFC:
>
> Add support for PSP encryption of TCP connections.
Hi Daniel,
This is much more of an observation than a review:
Unfortunately this patchset did not apply cleanly to net-next
at the time it was posted. This is a requirement for our CI.
So at least one more revision will be needed to address that.
--
pw-bot: changes-requested
prev parent reply other threads:[~2025-07-17 12:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 14:45 [PATCH net-next v4 00/19] add basic PSP encryption for TCP connections Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 01/19] psp: add documentation Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 02/19] psp: base PSP device support Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 03/19] net: modify core data structures for PSP datapath support Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 04/19] tcp: add datapath logic for PSP with inline key exchange Daniel Zahka
2025-07-16 17:25 ` Willem de Bruijn
2025-07-16 14:45 ` [PATCH net-next v4 05/19] psp: add op for rotation of device key Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 06/19] net: move sk_validate_xmit_skb() to net/core/dev.c Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 07/19] net: tcp: allow tcp_timewait_sock to validate skbs before handing to device Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 08/19] net: psp: add socket security association code Daniel Zahka
2025-07-16 17:37 ` Willem de Bruijn
2025-07-16 14:45 ` [PATCH net-next v4 09/19] net: psp: update the TCP MSS to reflect PSP packet overhead Daniel Zahka
2025-07-16 17:38 ` Willem de Bruijn
2025-07-16 14:45 ` [PATCH net-next v4 10/19] psp: track generations of device key Daniel Zahka
2025-07-16 17:44 ` Willem de Bruijn
2025-07-16 14:45 ` [PATCH net-next v4 11/19] net/mlx5e: Support PSP offload functionality Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 12/19] net/mlx5e: Implement PSP operations .assoc_add and .assoc_del Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 13/19] psp: provide encapsulation helper for drivers Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 14/19] net/mlx5e: Implement PSP Tx data path Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 15/19] net/mlx5e: Add PSP steering in local NIC RX Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 16/19] net/mlx5e: Configure PSP Rx flow steering rules Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 17/19] psp: provide decapsulation and receive helper for drivers Daniel Zahka
2025-07-16 17:45 ` Willem de Bruijn
2025-07-16 14:45 ` [PATCH net-next v4 18/19] net/mlx5e: Add Rx data path offload Daniel Zahka
2025-07-16 14:45 ` [PATCH net-next v4 19/19] net/mlx5e: Implement PSP key_rotate operation Daniel Zahka
2025-07-17 12:43 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717124359.GF27043@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=corbet@lwn.net \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jianbol@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=raeds@nvidia.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.