From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
Date: Fri, 18 Jul 2025 09:44:39 +0200 [thread overview]
Message-ID: <2025071808-jogger-snowflake-1911@gregkh> (raw)
In-Reply-To: <20250718034913.49300-1-ignacio.pena87@gmail.com>
On Thu, Jul 17, 2025 at 11:49:13PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning:
> "WARNING: static const char * array should probably be
> static const char * const"
>
> This makes both the array and its contents immutable, which is the
> intended behavior for these constant string arrays:
> - g_fbmode: array of framebuffer mode strings
> - fixId: array of framebuffer device names
>
> Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Always test-build your patches so you don't break maintainers workflow
by submitting patches that break the build :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-18 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 3:49 [PATCH 1/2] staging: sm750fb: make const arrays static const char * const Ignacio Peña
2025-07-18 7:44 ` Greg Kroah-Hartman [this message]
2025-07-18 14:53 ` Dan Carpenter
2025-07-21 23:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071808-jogger-snowflake-1911@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.