All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: rmk+kernel@armlinux.org.uk, Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Tony Lindgren <tony@atomide.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [resend][PATCH v2] arm: omap2: use string choices helper
Date: Fri, 18 Jul 2025 10:14:47 +0200	[thread overview]
Message-ID: <20250718101447.4e6ac258@akair> (raw)
In-Reply-To: <87ikjq5kqm.wl-kuninori.morimoto.gx@renesas.com>

Am Fri, 18 Jul 2025 01:52:01 +0000
schrieb Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:

> We can use string choices helper, let's use it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

> ---
>  arch/arm/mach-omap2/board-n8x0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
> index ff2a4a4d8220..969265d5d5c6 100644
> --- a/arch/arm/mach-omap2/board-n8x0.c
> +++ b/arch/arm/mach-omap2/board-n8x0.c
> @@ -167,7 +167,7 @@ static int n8x0_mmc_set_power_menelaus(struct device *dev, int slot,
>  
>  #ifdef CONFIG_MMC_DEBUG
>  	dev_dbg(dev, "Set slot %d power: %s (vdd %d)\n", slot + 1,
> -		power_on ? "on" : "off", vdd);
> +		str_on_off(power_on), vdd);
>  #endif
>  	if (slot == 0) {
>  		if (!power_on)



  reply	other threads:[~2025-07-18  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18  1:52 [resend][PATCH v2] arm: omap2: use string choices helper Kuninori Morimoto
2025-07-18  8:14 ` Andreas Kemnade [this message]
2025-09-08 21:31 ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718101447.4e6ac258@akair \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=khilman@baylibre.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.