From: Simon Horman <horms@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: ioana.ciornei@nxp.com, davem@davemloft.net,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2 3/3] dpaa2-switch: Fix device reference count leak in MAC endpoint handling
Date: Fri, 18 Jul 2025 15:43:13 +0100 [thread overview]
Message-ID: <20250718144313.GH2459@horms.kernel.org> (raw)
In-Reply-To: <20250717022309.3339976-3-make24@iscas.ac.cn>
On Thu, Jul 17, 2025 at 10:23:09AM +0800, Ma Ke wrote:
> The fsl_mc_get_endpoint() function uses device_find_child() for
> localization, which implicitly calls get_device() to increment the
> device's reference count before returning the pointer. However, the
> caller dpaa2_switch_port_connect_mac() fails to properly release this
> reference in multiple scenarios. We should call put_device() to
> decrement reference count properly.
>
> As comment of device_find_child() says, 'NOTE: you will need to drop
> the reference with put_device() after use'.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 84cba72956fd ("dpaa2-switch: integrate the MAC endpoint support")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-18 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 2:23 [PATCH net v2 1/3] bus: fsl-mc: Fix potential double device reference in fsl_mc_get_endpoint() Ma Ke
2025-07-17 2:23 ` [PATCH net v2 2/3] dpaa2-eth: Fix device reference count leak in MAC endpoint handling Ma Ke
2025-07-17 13:26 ` Ioana Ciornei
2025-07-18 14:42 ` Simon Horman
2025-07-17 2:23 ` [PATCH net v2 3/3] dpaa2-switch: " Ma Ke
2025-07-17 13:23 ` Ioana Ciornei
2025-07-18 14:43 ` Simon Horman [this message]
2025-07-17 13:15 ` [PATCH net v2 1/3] bus: fsl-mc: Fix potential double device reference in fsl_mc_get_endpoint() Ioana Ciornei
2025-07-18 14:39 ` Simon Horman
2025-07-19 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718144313.GH2459@horms.kernel.org \
--to=horms@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.