From: Jakub Kicinski <kuba@kernel.org>
To: Krishna Kumar <krikku@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
tom@herbertland.com, pabeni@redhat.com, horms@kernel.org,
sdf@fomichev.me, kuniyu@google.com, ahmed.zaki@intel.com,
aleksander.lobakin@intel.com, atenart@kernel.org,
jdamato@fastly.com, krishna.ku@flipkart.com
Subject: Re: [PATCH v3 net-next 1/2] net: Prevent RPS table overwrite for active flows
Date: Fri, 18 Jul 2025 17:58:47 -0700 [thread overview]
Message-ID: <20250718175847.4f4a834c@kernel.org> (raw)
In-Reply-To: <20250717075659.2725245-2-krikku@gmail.com>
On Thu, 17 Jul 2025 13:26:57 +0530 Krishna Kumar wrote:
> + * Return values:
> + * True: Flow has recent activity.
> + * False: Flow does not have recent activity.
This is not recognized as valid kdoc formatting:
Warning: net/core/dev.c:4856 No description found for return value of 'rps_flow_is_active'
I don't think we need to enumerate this trivial set of possibilities,
how about:
* Return: true if flow was recently active.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-19 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 11:24 [PATCH v2 net-next 0/2] net: RPS table overwrite prevention and flow_id caching Krishna Kumar
2025-07-15 11:24 ` [PATCH v2 net-next 1/2] net: Prevent RPS table overwrite for active flows Krishna Kumar
2025-07-16 4:20 ` kernel test robot
2025-07-15 11:24 ` [PATCH v2 net-next 2/2] net: Cache hash and flow_id to avoid recalculation Krishna Kumar
2025-07-17 7:56 ` [PATCH v3 net-next 0/2] net: RPS table overwrite prevention and flow_id caching Krishna Kumar
2025-07-17 7:56 ` [PATCH v3 net-next 1/2] net: Prevent RPS table overwrite for active flows Krishna Kumar
2025-07-19 0:58 ` Jakub Kicinski [this message]
2025-07-20 4:53 ` Krishna Kumar
2025-07-17 7:56 ` [PATCH v3 net-next 2/2] net: Cache hash and flow_id to avoid recalculation Krishna Kumar
2025-07-17 13:45 ` [PATCH v3 net-next 0/2] net: RPS table overwrite prevention and flow_id caching Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718175847.4f4a834c@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=krikku@gmail.com \
--cc=krishna.ku@flipkart.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.