All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, longli@microsoft.com, jgg@ziepe.ca,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: add support of multiple ports
Date: Sun, 20 Jul 2025 11:24:27 +0300	[thread overview]
Message-ID: <20250720082427.GF402218@unreal> (raw)
In-Reply-To: <1752834048-31696-1-git-send-email-kotaranov@linux.microsoft.com>

On Fri, Jul 18, 2025 at 03:20:48AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> If the HW indicates support of multiple ports for rdma, create an IB device
> with a port per netdev in the ethernet mana driver.
> 
> CM is only available on port 1, but RC QPs are supported on all
> ports.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
>  drivers/infiniband/hw/mana/device.c  | 107 +++++++++++++--------------
>  drivers/infiniband/hw/mana/main.c    |  13 +++-
>  drivers/infiniband/hw/mana/mana_ib.h |   1 +
>  3 files changed, 64 insertions(+), 57 deletions(-)

mana_get_primary_netdev() can return NULL.

You should check return value even it can't be happen or remove "if
(port_index >= ac->num_ports)" that returns NULL.

Thanks

      reply	other threads:[~2025-07-20  8:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 10:20 [PATCH rdma-next 1/1] RDMA/mana_ib: add support of multiple ports Konstantin Taranov
2025-07-20  8:24 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250720082427.GF402218@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.