From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E4F2C83F25 for ; Mon, 21 Jul 2025 12:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jsNY08z4QHFSK9LmbMcNpX5sDKMWDzvbhuxpJX7UE4A=; b=gKYLccGIkxeraNCy+xoe2N1zPd AcGYz8/o+BGKs3Jsj1zjKAlVUXrqDHYHgwSqjRnb+WuW49SIfmQfKKA/bSwoJCNbCljq1f0ZJW4A+ QihGeGvHkzUrqenYsEagvS94UtA0KbQY1Z9rLRvfN/wgm+C/OaAhqvGJM1FtexHQtCQ/Jyt2vvjMG 4Tslk+CSjVaJQzblKvaRJUjzMqSpbFY8N/sWqvldROgl4KQiT1drUzJFJ6aIVdxmyL6iO0aPcCxiO oJlS68mklLMJTSMZQjVuiXIxb0x0qPS9DC14byaJGHxpHKeVko6SDK4/2I9+V370NOksLar0rbEl0 JPRu7bUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1udpSM-0000000HEip-1WTJ; Mon, 21 Jul 2025 12:17:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1udo4W-0000000Gzw4-1kMu for linux-arm-kernel@lists.infradead.org; Mon, 21 Jul 2025 10:48:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 257C6153B; Mon, 21 Jul 2025 03:48:31 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A7CF3F66E; Mon, 21 Jul 2025 03:48:36 -0700 (PDT) Date: Mon, 21 Jul 2025 11:48:34 +0100 From: Leo Yan To: Suzuki K Poulose Cc: Mike Leach , James Clark , Anshuman Khandual , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 04/10] coresight: Appropriately disable programming clocks Message-ID: <20250721104834.GC3137075@e132581.arm.com> References: <20250627-arm_cs_fix_clock_v4-v4-0-0ce0009c38f8@arm.com> <20250627-arm_cs_fix_clock_v4-v4-4-0ce0009c38f8@arm.com> <5a5f1355-563d-498a-9dec-3479a257b3e6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a5f1355-563d-498a-9dec-3479a257b3e6@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250721_034840_490927_8DE68E62 X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 21, 2025 at 10:15:22AM +0100, Suzuki Kuruppassery Poulose wrote: [...] > > diff --git a/include/linux/coresight.h b/include/linux/coresight.h > > index 4ac65c68bbf44b98db22c3dad2d83a224ce5278e..dd2b4cc7a2b70cf060a3207548fe80e3824c489f 100644 > > --- a/include/linux/coresight.h > > +++ b/include/linux/coresight.h > > @@ -480,26 +480,16 @@ static inline bool is_coresight_device(void __iomem *base) > > * Returns: > > * > > * clk - Clock is found and enabled > > - * NULL - clock is not found > > This is still valid, right ? No. Since this patch uses devm_clk_get_enabled() to get a clock, if the pclk is not found, it returns -ENOENT (see of_parse_clkspec()). Only the optional clock APIs (e.g., devm_clk_get_optional_enabled()) return a NULL pointer instead of -ENOENT when the clock is not found. Thanks, Leo