From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
To: Michal Simek <monstr@monstr.eu>
Cc: u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Casey Connolly <casey.connolly@linaro.org>,
Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH v2 01/25] arm_ffa: Remove NULL pointer check for ops
Date: Mon, 21 Jul 2025 12:33:19 +0100 [thread overview]
Message-ID: <20250721113310.GA63677@e130802.arm.com> (raw)
In-Reply-To: <CAHTX3dJgT0FB9f9Ybes=V+xUt1M2wXPXNhqxVtzcAGysNeLJGA@mail.gmail.com>
Hi Michal,
> pá 11. 7. 2025 v 16:49 odesílatel <abdellatif.elkhlifi@arm.com> napsal:
> >
> > From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> >
> > Remove NULL pointer check for ops
> >
> > uclasses that use ops typically don't check for NULL.
> >
> > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > Cc: Jens Wiklander <jens.wiklander@linaro.org>
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Casey Connolly <casey.connolly@linaro.org>
> > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> >
> > ---
> >
> > Changelog of changes:
> > ===========================
> >
> > v2:
> >
> > * As suggested by Heinrich: The commit is renamed and the ops NULL check removed
> >
> > v1:
> >
> > * Commit title was "arm_ffa: Add NULL pointer check to the uclass driver operations"
> >
> > drivers/firmware/arm-ffa/arm-ffa-uclass.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/arm-ffa/arm-ffa-uclass.c b/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> > index 96c64964bb7..32dd9458da9 100644
> > --- a/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> > +++ b/drivers/firmware/arm-ffa/arm-ffa-uclass.c
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: GPL-2.0+
> > /*
> > - * Copyright 2022-2023 Arm Limited and/or its affiliates <open-source-office@arm.com>
> > + * Copyright 2022-2023, 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>
> > *
> > * Authors:
> > * Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > --
> > 2.25.1
> >
>
> That commit message is not matching what you do here.
Thank you. Your comment has been addressed in v3 patchset.
The commit has been removed and the copyright text moved
to the next commit.
Cheers
Abdellatif
next prev parent reply other threads:[~2025-07-21 11:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 14:48 [PATCH v2 00/25] Introduce Firmware Update Support for Arm PSA abdellatif.elkhlifi
2025-07-11 14:48 ` [PATCH v2 01/25] arm_ffa: Remove NULL pointer check for ops abdellatif.elkhlifi
2025-07-14 12:18 ` Michal Simek
2025-07-21 11:33 ` Abdellatif El Khlifi [this message]
2025-07-11 14:48 ` [PATCH v2 02/25] arm_ffa: Add FFA_MEM_SHARE support abdellatif.elkhlifi
2025-08-20 17:38 ` Jens Wiklander
2025-08-20 17:53 ` Heinrich Schuchardt
2025-07-11 14:48 ` [PATCH v2 03/25] arm_ffa: Add FFA_MEM_RECLAIM support abdellatif.elkhlifi
2025-08-21 13:24 ` Jens Wiklander
2025-07-11 14:48 ` [PATCH v2 04/25] arm_ffa: sandbox: Replace the emulator error log with debug log abdellatif.elkhlifi
2025-07-11 14:48 ` [PATCH v2 05/25] arm_ffa: sandbox: Improve the readability of clearing the X registers abdellatif.elkhlifi
2025-07-11 14:48 ` [PATCH v2 06/25] arm_ffa: sandbox: Add FFA_MEM_SHARE emulation abdellatif.elkhlifi
2025-07-11 14:48 ` [PATCH v2 07/25] arm_ffa: sandbox: Add FFA_MEM_SHARE tests abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 08/25] arm_ffa: sandbox: Add FFA_MEM_RECLAIM emulation abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 09/25] arm_ffa: sandbox: Add FFA_MEM_RECLAIM tests abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 10/25] fwu_arm_psa: Initialize the update agent abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 11/25] fwu_arm_psa: Read the FWU directory through get_image_info() abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 12/25] fwu_arm_psa: Add staging ABIs abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 13/25] efi_loader: fwu_arm_psa: Add set_image and get_image_info support abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 14/25] efi_loader: fwu_arm_psa: Keep the FMP payload header abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 15/25] efi_loader: fwu: fwu_arm_psa: Skip accepting the payload after set_image() abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 16/25] efi_loader: fwu: fwu_arm_psa: Disable trial state handling abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 17/25] fwu_arm_psa: Add FWU acceptance mechanism abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 18/25] fwu_arm_psa: Add ESRT support abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 19/25] fwu_arm_psa: Add ExitBootService() notification handler abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 20/25] efi_loader: capsule: Add runtime capsule flags checks abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 21/25] fwu_arm_psa: corstone1000: Enable FWU support abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 22/25] fwu_arm_psa: corstone1000: Perform bank logic when reading boot index abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 23/25] fwu_arm_psa: corstone1000: Notify SE Proxy SP on ExitBootService() abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 24/25] fwu_arm_psa: corstone1000: Set Boot0001 for on-disk FWU abdellatif.elkhlifi
2025-07-11 14:49 ` [PATCH v2 25/25] fwu_arm_psa: Document FWU support for Arm PSA abdellatif.elkhlifi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721113310.GA63677@e130802.arm.com \
--to=abdellatif.elkhlifi@arm.com \
--cc=casey.connolly@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jens.wiklander@linaro.org \
--cc=monstr@monstr.eu \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.