All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: tests: Annotate worker to be on stack
Date: Mon, 21 Jul 2025 20:16:03 -0700	[thread overview]
Message-ID: <20250722031603.GA1298@sol> (raw)
In-Reply-To: <20250721231917.3182029-1-linux@roeck-us.net>

On Mon, Jul 21, 2025 at 04:19:17PM -0700, Guenter Roeck wrote:
> The following warning traceback is seen if object debugging is enabled
> with the new crypto test code.
> 
> ODEBUG: object 9000000106237c50 is on stack 9000000106234000, but NOT annotated.
> ------------[ cut here ]------------
> WARNING: lib/debugobjects.c:655 at lookup_object_or_alloc.part.0+0x19c/0x1f4, CPU#0: kunit_try_catch/468
> ...
> 
> This also results in a boot stall when running the code in qemu:loongarch.
> 
> Initializing the worker with INIT_WORK_ONSTACK() fixes the problem.
> 
> Cc: Eric Biggers <ebiggers@kernel.org>
> Fixes: 950a81224e8b ("lib/crypto: tests: Add hash-test-template.h and gen-hash-testvecs.py")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  lib/crypto/tests/hash-test-template.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

Thanks!

I also added the following to the debugging kconfig that I use:

    CONFIG_DEBUG_OBJECTS_FREE=y
    CONFIG_DEBUG_OBJECTS_TIMERS=y
    CONFIG_DEBUG_OBJECTS_WORK=y
    CONFIG_DEBUG_OBJECTS_RCU_HEAD=y
    CONFIG_DEBUG_OBJECTS_PERCPU_COUNTER=y

- Eric

  parent reply	other threads:[~2025-07-22  3:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21 23:19 [PATCH] lib/crypto: tests: Annotate worker to be on stack Guenter Roeck
2025-07-22  0:05 ` Ard Biesheuvel
2025-07-22  3:16 ` Eric Biggers [this message]
2025-07-24 14:19   ` Guenter Roeck
2025-07-24 16:26     ` Eric Biggers
2025-07-24 17:03       ` Guenter Roeck
2025-07-24 17:36         ` Eric Biggers
2025-07-24 18:29           ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722031603.GA1298@sol \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.