From: Jakub Kicinski <kuba@kernel.org>
To: Suchit K <suchitkarunakaran@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, sdf@fomichev.me, kuniyu@google.com,
aleksander.lobakin@intel.com, netdev@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Revert tx queue length on partial failure in dev_qdisc_change_tx_queue_len()
Date: Tue, 22 Jul 2025 07:33:30 -0700 [thread overview]
Message-ID: <20250722073330.5bf59b6d@kernel.org> (raw)
In-Reply-To: <CAO9wTFhghrrzH2ysTiBqNrZ1dbb001Y6rWYiKRTC2R8PBm-Zog@mail.gmail.com>
On Tue, 22 Jul 2025 19:26:01 +0530 Suchit K wrote:
> I'm sorry for the oversight. I'll send a v2 patch shortly to fix it.
Please note that in networking we ask that new versions of patches not
be resubmitted within 24h of previous posting:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
> In the meantime, could you please give me some insights on testing
> this change? Also, apart from the unsigned int blunder, does the
> overall approach look reasonable? I’d be grateful for any suggestions
> or comments. Thank you.
Hopefully someone reviews before you repost, I didn't look further once
I noticed the static analysis warning.
next prev parent reply other threads:[~2025-07-22 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:15 [PATCH] net: Revert tx queue length on partial failure in dev_qdisc_change_tx_queue_len() Suchit Karunakaran
2025-07-22 13:36 ` Jakub Kicinski
2025-07-22 13:56 ` Suchit K
2025-07-22 14:33 ` Jakub Kicinski [this message]
2025-07-22 14:48 ` Suchit K
2025-07-22 15:41 ` Eric Dumazet
2025-07-22 16:21 ` Suchit K
2025-07-22 16:28 ` Eric Dumazet
2025-07-22 16:45 ` Suchit K
2025-07-23 18:17 ` Suchit K
2025-07-23 18:36 ` Eric Dumazet
2025-07-25 17:47 ` Cong Wang
2025-07-26 11:02 ` Suchit K
2025-07-23 15:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722073330.5bf59b6d@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuniyu@google.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=suchitkarunakaran@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.