From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] rv: Remove rv_reactor's reference counter
Date: Tue, 22 Jul 2025 10:27:40 +0200 [thread overview]
Message-ID: <20250722082740.a0kYzRv_@linutronix.de> (raw)
In-Reply-To: <eabfae8b0f29c88437cc51af21797e869d99aef6.camel@redhat.com>
On Mon, Jul 21, 2025 at 05:49:02PM +0200, Gabriele Monaco wrote:
> Yeah I get your point. If I understand you correctly, what's broken is
> that we just return EBUSY and ignore that on __exit instead of doing
> something about it (set nop to all monitors using this reactor).
Yeah, EBUSY is ignored.
> I wonder if we shouldn't also fix this (using the module refcount).
> But that can be done in the future, I'm not even sure reactors as
> modules currently work.
Yes, let's worry about it when we allow building reactors as modules.
> Also, I'd need to verify this but depending on the order of exit
> functions, we might be seeing the same problems with built-in reactors
> when active on shutdown. I'm going to play a bit with this and see if
> this workaround of not deleting the reactor was introduced for that (I
> doubt though).
I'm not sure I follow. exit functions are never called for built-in
reactors. They are even discarded out of the built image.
Nam
next prev parent reply other threads:[~2025-07-22 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 9:47 [PATCH 0/6] rv: Clean up & simplify Nam Cao
2025-07-21 9:47 ` [PATCH 1/6] rv: Remove unused field in struct rv_monitor_def Nam Cao
2025-07-21 13:01 ` Gabriele Monaco
2025-07-21 9:47 ` [PATCH 2/6] rv: Merge struct rv_monitor_def into struct rv_monitor Nam Cao
2025-07-21 14:13 ` Gabriele Monaco
2025-07-21 9:47 ` [PATCH 3/6] rv: Merge struct rv_reactor_def into struct rv_reactor Nam Cao
2025-07-21 14:29 ` Gabriele Monaco
2025-07-21 9:47 ` [PATCH 4/6] rv: Remove rv_reactor's reference counter Nam Cao
2025-07-21 13:20 ` Gabriele Monaco
2025-07-21 14:04 ` Nam Cao
2025-07-21 15:49 ` Gabriele Monaco
2025-07-22 8:27 ` Nam Cao [this message]
2025-07-22 8:30 ` Gabriele Monaco
2025-07-21 9:47 ` [PATCH 5/6] rv: Remove the nop reactor Nam Cao
2025-07-21 10:29 ` Gabriele Monaco
2025-07-21 14:10 ` Nam Cao
2025-07-21 9:47 ` [PATCH 6/6] rv: Remove struct rv_monitor::reacting Nam Cao
2025-07-21 14:38 ` Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722082740.a0kYzRv_@linutronix.de \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.