From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49D772E03E8 for ; Tue, 22 Jul 2025 10:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753179620; cv=none; b=CHXaTvU3SXYTdFrSPPfe2vPRquL1SWnnmQHt55O/tFW2v4TrcUcO3NYzpSTld47ZMHkA43FAG5TCQBxSduD77Jf0edBDV9GSNb7AM78ccOJl0gIVf51dnMl5ozjiovCgdT/4dofHtFqLB48NjZKFp98xX/PAaETNbLtle35k4j0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753179620; c=relaxed/simple; bh=FY/g2nytNwGTYIlxhvIPA3OaPQkLlCJPhaAgPjZYxmQ=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JSNplPwdf/bsB6dSodxw+XOFsFyfwrhA5C1L9teB4wE//U06G31QbQWVaGXJlx4yXIEi4+HETLAhHd8slLecZzpdXPyfOsM41JwrhOLyZOlfaTLLJfGaU/i3YFz4BGsGfJUZ+jDwxoE04aMaWtyv1ZxxdjhDBlBlG0slS4Xj8PM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bmY8949v4z6GDDg; Tue, 22 Jul 2025 18:16:25 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6FA181400E3; Tue, 22 Jul 2025 18:20:15 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 22 Jul 2025 12:20:14 +0200 Date: Tue, 22 Jul 2025 11:20:13 +0100 From: Jonathan Cameron To: Guenter Roeck CC: , Krzysztof Kozlowski , Mark Brown , , , Andrei Lalaev , Chanh Nguyen , Conor Dooley , Fabio Estevam , Grant Peltier , Krzysztof Kozlowski , Laurent Pinchart , Michal Simek , Naresh Solanki , Pengutronix Kernel Team , Rob Herring , Rodrigo Gobbi , Sascha Hauer , Shawn Guo , , , Subject: Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device Message-ID: <20250722112013.0000597e@huawei.com> In-Reply-To: <2e9c96c6-6dfb-4232-a9ab-a3e78b718fc2@roeck-us.net> References: <20250719063355.73111-1-hs@denx.de> <175311337130.327079.7374455187420344577.b4-ty@kernel.org> <8a8106ea-83d3-e02a-9ae7-ea4a66e4c248@denx.de> <2e9c96c6-6dfb-4232-a9ab-a3e78b718fc2@roeck-us.net> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To frapeml500008.china.huawei.com (7.182.85.71) On Mon, 21 Jul 2025 21:58:10 -0700 Guenter Roeck wrote: > On 7/21/25 21:05, Heiko Schocher wrote: > > Hello Krzysztof, > >=20 > > On 21.07.25 18:24, Krzysztof Kozlowski wrote: =20 > >> On 21/07/2025 17:56, Mark Brown wrote: =20 > >>> On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote: =20 > >>>> This series introduces the changes needed for trivial spi > >>>> based sensors from ABB, currently operated from userspace. > >>>> > >>>> The last patch adds the spidevices to the DTS files, already > >>>> in mainline. > >>>> > >>>> make dtbs_check showed no errors/warnings for the dts files > >>>> > >>>> [...] =20 > >>> > >>> Applied to > >>> > >>> =A0=A0=A0 https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi= .git for-next > >>> > >>> Thanks! > >>> > >>> [1/3] dt-bindings: trivial-devices: Document ABB sensors > >>> =A0=A0=A0=A0=A0=A0 commit: aad2f87cbcab56b322109d26d7b11842a09df91f > >>> [2/3] spi: spidev: Add an entry for the ABB spi sensors > >>> =A0=A0=A0=A0=A0=A0 commit: d60f7cab7c04944a79af16caa43c141e780a59c6 > >>> =20 > >> > >> > >> That's unexpected, Mark. Patches received two objections/comments and I > >> don't think discussion was resolved. > >> > >> ABB is huge company, probably making hundreds or more of sensors. The > >> patchset basically claims that all of them work with spidev. It does n= ot > >> providing any model names or details, so it seems really incomplete to > >> call them trivial devices. =20 > >=20 > > I do not know how many different sensors they have, nor if that departm= ent can > > speak for the whole company... > >=20 > > What I have as information is: > > https://lore.kernel.org/linux-spi/2477dc64-92a0-9dc9-d168-56646d0d796e@= denx.de/ > >=20 > > and I get no more information about them currently. May I should > > add some sort of trivial into compatible name? Something like > >=20 > > "abb,spi-trivial-sensor" > > or > > "abb,spidev-trivial-sensor" > >=20 > > which makes it clearer, that only ABB trivial sensor, controlled throug= h spidev > > driver, is connected here? > > =20 >=20 > FWIW, I always thought that devicetree is not supposed to contain such ge= neric > information. Is it even appropriate to list something like this in device= tree > in the first place ? >=20 > If so, what prevents anyone from submitting hundreds of > ",spidev-trivial-" entries, using the same line of = argument ? Agreed. These should have separate compatibles based on what any OS etc might want to bind to them. Just because their model in Linux is spidev etc that shouldn't mean a generic ID is appropriate. Can we at least have some examples to motivate the discussion? Jonathan >=20 > Guenter >=20