From: Al Viro <viro@zeniv.linux.org.uk>
To: Antoni Pokusinski <apokusinski01@gmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
syzbot+fa88eb476e42878f2844@syzkaller.appspotmail.com
Subject: Re: [PATCH] hpfs: add checks for ea addresses
Date: Wed, 23 Jul 2025 03:45:48 +0100 [thread overview]
Message-ID: <20250723024548.GM2580412@ZenIV> (raw)
In-Reply-To: <20250720123426.132651-1-apokusinski01@gmail.com>
On Sun, Jul 20, 2025 at 02:34:27PM +0200, Antoni Pokusinski wrote:
> ea_end = fnode_end_ea(fnode);
> - for (ea = fnode_ea(fnode); ea < ea_end; ea = next_ea(ea))
> + for (ea = fnode_ea(fnode); ea < ea_end && ea_valid_addr(fnode, ea); ea = next_ea(ea))
That looks really fishy. If nothing else, your ea_valid_addr() is a range check;
are there any situations where we would want to allow fnode_ea() and fnode_end_ea()
be out of that range?
next prev parent reply other threads:[~2025-07-23 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 12:34 [PATCH] hpfs: add checks for ea addresses Antoni Pokusinski
2025-07-20 13:49 ` [syzbot] [fs?] KASAN: use-after-free Read in hpfs_get_ea syzbot
2025-07-23 2:45 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-20 14:22 [PATCH] hpfs: add checks for ea addresses Antoni Pokusinski
2025-07-21 19:51 ` Mikulas Patocka
2025-07-21 22:42 ` Antoni Pokusinski
2025-07-24 14:21 ` Mikulas Patocka
2025-07-24 18:44 ` Antoni Pokusinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723024548.GM2580412@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=apokusinski01@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fa88eb476e42878f2844@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.