From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, dsahern@kernel.org, andrew+netdev@lunn.ch,
horms@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: Warn when overriding referenced dst entry
Date: Wed, 23 Jul 2025 08:24:07 -0700 [thread overview]
Message-ID: <20250723082407.06686876@kernel.org> (raw)
In-Reply-To: <aID8FaYlyuVjeOH_@mini-arch>
On Wed, 23 Jul 2025 08:13:25 -0700 Stanislav Fomichev wrote:
> > > +{
> > > + DEBUG_NET_WARN_ON_ONCE(skb_dst(skb) &&
> > > + !(skb->_skb_refdst & SKB_DST_NOREF));
> >
> > Why not
> >
> > DEBUG_NET_WARN_ON_ONCE(skb->_skb_refdst & SKB_DST_PTRMASK);
> >
> > ?
>
> That's more precise, agreed!
Just to be clear -- looks like I ate the
!(skb->_skb_refdst & SKB_DST_NOREF)
part part of the condition. I think we still want that.
next prev parent reply other threads:[~2025-07-23 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 21:02 [PATCH net 1/2] vrf: Drop existing dst reference in vrf_ip6_input_dst Stanislav Fomichev
2025-07-22 21:02 ` [PATCH net 2/2] net: Warn when overriding referenced dst entry Stanislav Fomichev
2025-07-23 2:00 ` Jakub Kicinski
2025-07-23 15:13 ` Stanislav Fomichev
2025-07-23 15:24 ` Jakub Kicinski [this message]
2025-07-23 15:30 ` Stanislav Fomichev
2025-07-23 9:09 ` [syzbot ci] Re: vrf: Drop existing dst reference in vrf_ip6_input_dst syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723082407.06686876@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.