All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pratap Nirujogi <pratap.nirujogi@amd.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [agd5f:kq_resets 2304/2346] drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:174: warning: Function parameter or struct member 'dmabuf' not described in 'isp_user_buffer_alloc'
Date: Wed, 23 Jul 2025 17:18:15 +0200	[thread overview]
Message-ID: <202507231758.GS93qDWN-lkp@intel.com> (raw)

tree:   https://gitlab.freedesktop.org/agd5f/linux.git kq_resets
head:   524eebfdd4b30fd63ca774d7ea346bcf0e8e76b1
commit: 5cab8cc383a58877fa0fd9eb566e68b815500cdf [2304/2346] drm/amd/amdgpu: Add helper functions for isp buffers
config: i386-buildonly-randconfig-2003-20250723 (https://download.01.org/0day-ci/archive/20250723/202507231758.GS93qDWN-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250723/202507231758.GS93qDWN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507231758.GS93qDWN-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:174: warning: Function parameter or struct member 'dmabuf' not described in 'isp_user_buffer_alloc'
>> drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:174: warning: Excess function parameter 'dma_buf' description in 'isp_user_buffer_alloc'


vim +174 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c

   153	
   154	/**
   155	 * isp_user_buffer_alloc - create user buffer object (BO) for isp
   156	 *
   157	 * @dev: isp device handle
   158	 * @dma_buf: DMABUF handle for isp buffer allocated in system memory
   159	 * @buf_obj: GPU buffer object handle to initialize
   160	 * @buf_addr: GPU addr of the pinned BO to initialize
   161	 *
   162	 * Imports isp DMABUF to allocate and pin a user BO for isp internal use. It does
   163	 * GART alloc to generate GPU addr for BO to make it accessible through the
   164	 * GART aperture for ISP HW.
   165	 *
   166	 * This function is exported to allow the V4L2 isp device external to drm device
   167	 * to create and access the isp user BO.
   168	 *
   169	 * Returns:
   170	 * 0 on success, negative error code otherwise.
   171	 */
   172	int isp_user_buffer_alloc(struct device *dev, void *dmabuf,
   173				  void **buf_obj, u64 *buf_addr)
 > 174	{
   175		struct platform_device *ispdev = to_platform_device(dev);
   176		const struct isp_platform_data *isp_pdata;
   177		struct amdgpu_device *adev;
   178		struct mfd_cell *mfd_cell;
   179		struct amdgpu_bo *bo;
   180		u64 gpu_addr;
   181		int ret;
   182	
   183		if (WARN_ON(!ispdev))
   184			return -ENODEV;
   185	
   186		if (WARN_ON(!buf_obj))
   187			return -EINVAL;
   188	
   189		if (WARN_ON(!buf_addr))
   190			return -EINVAL;
   191	
   192		mfd_cell = &ispdev->mfd_cell[0];
   193		if (!mfd_cell)
   194			return -ENODEV;
   195	
   196		isp_pdata = mfd_cell->platform_data;
   197		adev = isp_pdata->adev;
   198	
   199		ret = is_valid_isp_device(ispdev->dev.parent, adev->dev);
   200		if (ret)
   201			return ret;
   202	
   203		ret = amdgpu_bo_create_isp_user(adev, dmabuf,
   204						AMDGPU_GEM_DOMAIN_GTT, &bo, &gpu_addr);
   205		if (ret) {
   206			drm_err(&adev->ddev, "failed to alloc gart user buffer (%d)", ret);
   207			return ret;
   208		}
   209	
   210		*buf_obj = (void *)bo;
   211		*buf_addr = gpu_addr;
   212	
   213		return 0;
   214	}
   215	EXPORT_SYMBOL(isp_user_buffer_alloc);
   216	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-07-23 17:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 15:18 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-13  5:10 [agd5f:kq_resets 2304/2346] drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:174: warning: Function parameter or struct member 'dmabuf' not described in 'isp_user_buffer_alloc' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202507231758.GS93qDWN-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pratap.nirujogi@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.