From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] checkpatch: enforce 12-char SHA for Fixes tags
Date: Wed, 23 Jul 2025 07:18:51 +0200 [thread overview]
Message-ID: <2025072354-spruce-step-4433@gregkh> (raw)
In-Reply-To: <20250723030257.66560-2-ignacio.pena87@gmail.com>
On Tue, Jul 22, 2025 at 11:02:57PM -0400, Ignacio Peña wrote:
> The kernel documentation recommends 12 character SHA-1 hashes
> for Fixes tags. The current code allows 12-40 characters but
> we should enforce exactly 12 for consistency.
>
> The regex is changed from {12,40} to {12} and the warning
> message updated accordingly.
>
> Link: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
No list of what changed from v1?
And also, why make this change at all? 12+ is fine, I haven't seen
people use huge values in the past, have you?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-23 5:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 16:24 [PATCH 1/3] checkpatch: warn about novice phrases in commit messages Ignacio Peña
2025-07-21 16:24 ` [PATCH 2/3] checkpatch: enforce 12-char SHA for Fixes tags Ignacio Peña
2025-07-22 8:00 ` Greg Kroah-Hartman
2025-07-21 16:24 ` [PATCH 3/3] checkpatch: suggest including testing evidence Ignacio Peña
2025-07-22 7:59 ` Greg Kroah-Hartman
2025-07-22 17:58 ` [PATCH 1/3] checkpatch: warn about novice phrases in commit messages Joe Perches
2025-07-23 3:02 ` [PATCH v2 1/2] " Ignacio Peña
2025-07-23 3:02 ` [PATCH v2 2/2] checkpatch: enforce 12-char SHA for Fixes tags Ignacio Peña
2025-07-23 5:18 ` Greg Kroah-Hartman [this message]
2025-07-23 3:26 ` [PATCH v2 1/2] checkpatch: warn about novice phrases in commit messages Joe Perches
2025-07-24 3:28 ` [PATCH v3] " Ignacio Peña
2025-07-24 7:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072354-spruce-step-4433@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=ignacio.pena87@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.