From: Dev Jain <dev.jain@arm.com>
To: akpm@linux-foundation.org, david@redhat.com
Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dev Jain <dev.jain@arm.com>
Subject: [PATCH v4 0/3] Optimizations for khugepaged
Date: Thu, 24 Jul 2025 10:52:58 +0530 [thread overview]
Message-ID: <20250724052301.23844-1-dev.jain@arm.com> (raw)
If the underlying folio mapped by the ptes is large, we can process those
ptes in a batch using folio_pte_batch().
For arm64 specifically, this results in a 16x reduction in the number of
ptep_get() calls, since on a contig block, ptep_get() on arm64 will iterate
through all 16 entries to collect a/d bits. Next, ptep_clear() will cause
a TLBI for every contig block in the range via contpte_try_unfold().
Instead, use clear_ptes() to only do the TLBI at the first and last
contig block of the range.
For split folios, there will be no pte batching; the batch size returned
by folio_pte_batch() will be 1. For pagetable split folios, the ptes will
still point to the same large folio; for arm64, this results in the
optimization described above, and for other arches, a minor improvement
is expected due to a reduction in the number of function calls and
batching atomic operations.
---
Rebased on today's mm-new - the v3 of this patchset was already in, so
I reverted those commits and then rebased on top of that.
mm-selftests pass.
v3->v4:
- Use unsigned int for nr_ptes and max_nr_ptes (David)
- Define the functions in patch 1 as inline functions with kernel docs
instead of macros (akpm)
v2->v3:
- Drop patch 3 (was merged separately)
- Add patch 1 (David)
- Coding style change, drop mapped_folio (Lorenzo)
v1->v2:
- Use for loop instead of do-while loop (Lorenzo)
- Remove folio_test_large check since the subpage-check condition
will imply that (Baolin)
- Combine patch 1 and 2 into this series, add new patch 3
David Hildenbrand (1):
mm: add get_and_clear_ptes() and clear_ptes()
Dev Jain (2):
khugepaged: Optimize __collapse_huge_page_copy_succeeded() by PTE
batching
khugepaged: Optimize collapse_pte_mapped_thp() by PTE batching
arch/arm64/mm/mmu.c | 2 +-
include/linux/pgtable.h | 45 ++++++++++++++++++++++++++++++++
mm/khugepaged.c | 58 +++++++++++++++++++++++++++--------------
mm/mremap.c | 2 +-
mm/rmap.c | 2 +-
5 files changed, 87 insertions(+), 22 deletions(-)
--
2.30.2
next reply other threads:[~2025-07-24 5:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 5:22 Dev Jain [this message]
2025-07-24 5:22 ` [PATCH v4 1/3] mm: add get_and_clear_ptes() and clear_ptes() Dev Jain
2025-07-24 9:31 ` Barry Song
2025-07-24 17:17 ` Lorenzo Stoakes
2025-07-29 14:30 ` Zi Yan
2025-07-24 5:23 ` [PATCH v4 2/3] khugepaged: Optimize __collapse_huge_page_copy_succeeded() by PTE batching Dev Jain
2025-07-24 17:55 ` Lorenzo Stoakes
2025-07-24 17:57 ` David Hildenbrand
2025-07-24 18:01 ` Lorenzo Stoakes
2025-07-24 18:02 ` Lorenzo Stoakes
2025-07-29 14:38 ` Zi Yan
2025-07-24 5:23 ` [PATCH v4 3/3] khugepaged: Optimize collapse_pte_mapped_thp() " Dev Jain
2025-07-24 18:07 ` Lorenzo Stoakes
2025-07-29 14:41 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724052301.23844-1-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.