From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC055C83F26 for ; Thu, 24 Jul 2025 09:20:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 77C834129D; Thu, 24 Jul 2025 09:20:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PY48jCt8Kom9; Thu, 24 Jul 2025 09:20:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E1D9741288 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1753348807; bh=Au08yxhes32pi74h+2+Y4ObUhls304Y/LMgbhIRZAsY=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=M8/ArfPodynmLJ4pRcnvkULHWXA5oRmZKhTgD/H/iLM+1CCWi5QISg4d2m3+R+bto bcqKF1F9S+GdLlpkZXiVcOhANweqRy+ZeCZOo+pHoFVecdnWL3E69NA3+phDAYHg1H jHyF09nwZWCvidlF6z143O7ERaE+//H/Rs0OmgQuHQV5sXE52bcUvbhHDKXVRGLFeS P7jcLp9SJIkFseJbI7ac9NyCFzuWNgad3WLOEKi1kJk+FLINaC0HJUJc1ew22UIzAZ x8x5I1QVU3KGweBZziz1UU29vxl49BosiDjY5+d0YV+rKhiEP0yht6yx+ZqHdOYY5l veX0RXEE/qMiw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id E1D9741288; Thu, 24 Jul 2025 09:20:07 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id BD8ED115 for ; Thu, 24 Jul 2025 09:20:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BAD7641288 for ; Thu, 24 Jul 2025 09:20:06 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0v0q-IlVo2op for ; Thu, 24 Jul 2025 09:20:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2B3BA41273 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2B3BA41273 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2B3BA41273 for ; Thu, 24 Jul 2025 09:20:06 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6ABF55C598D; Thu, 24 Jul 2025 09:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F229C4CEED; Thu, 24 Jul 2025 09:20:03 +0000 (UTC) Date: Thu, 24 Jul 2025 10:20:01 +0100 From: Simon Horman To: Joshua Hay Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Luigi Rizzo , Brian Vazquez , Madhu Chittim , Aleksandr Loktionov Message-ID: <20250724092001.GI1150792@horms.kernel.org> References: <20250718002150.2724409-1-joshua.a.hay@intel.com> <20250718002150.2724409-5-joshua.a.hay@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250718002150.2724409-5-joshua.a.hay@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753348805; bh=gRFHoDdViZAhEfGEzYU/dSV6M0YfSmmTUyLmjOCqTkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=csas9LGY3gRo4CflNztwworSXqvM8gHWVOt7FYpn4krG0uzPcST4ldUOXK9WiSfU+ Bl/gD///R2Xr1E+leO3FVoA/cmY7hrZsRWRGuf4zppDeRI2yzuSDciBKM9QeJU5YXF 3lUoU30S9zsyrSCJdbGjvAlBVyOAIIj7XClzYuzCSu33qjjIPQHa+hQPQ9CiGfH0hq 2RrLpttG9Y2Rr+AI6yRTXkj1QPGmmplS32ugXf96GFce1Bi01SIHjGkU0nlKqhI+od 8ZNTjLOEoHZBU0hByVSAZ2XGWWAbxEsN7uEsj8rRIeg8Qxm2R1sT1jlamSiJ26Gchc V1v7jSkIUff/g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=csas9LGY Subject: Re: [Intel-wired-lan] [PATCH net v2 4/6] idpf: replace flow scheduling buffer ring with buffer pool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jul 17, 2025 at 05:21:48PM -0700, Joshua Hay wrote: ... > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c ... > @@ -1959,10 +1966,29 @@ static bool idpf_tx_clean_buf_ring(struct idpf_tx_queue *txq, u16 compl_tag, > }; > u16 ntc, orig_idx = idx; > > + tx_buf = &txq->tx_buf[buf_id]; > + if (tx_buf->type == LIBETH_SQE_SKB) { > + if (skb_shinfo(tx_buf->skb)->tx_flags & SKBTX_IN_PROGRESS) > + idpf_tx_read_tstamp(txq, tx_buf->skb); > + > + libeth_tx_complete(tx_buf, &cp); > + idpf_post_buf_refill(txq->refillq, buf_id); > + } > + > + while (idpf_tx_buf_next(tx_buf) != IDPF_TXBUF_NULL) { > + u16 buf_id = idpf_tx_buf_next(tx_buf); > + > + tx_buf = &txq->tx_buf[buf_id]; > + libeth_tx_complete(tx_buf, &cp); > + idpf_post_buf_refill(txq->refillq, buf_id); > + } > + > + return true; This is not a full review. And I guess this is an artifact of the development of this patch-set. But the code in this function below this line appears to be unreachable. Flagged by Smatch. > + > tx_buf = &txq->tx_buf[idx]; > > if (unlikely(tx_buf->type <= LIBETH_SQE_CTX || > - idpf_tx_buf_compl_tag(tx_buf) != compl_tag)) > + idpf_tx_buf_compl_tag(tx_buf) != buf_id)) > return false; > > if (tx_buf->type == LIBETH_SQE_SKB) { ...