From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDA625FA3B; Thu, 24 Jul 2025 10:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753352094; cv=none; b=DXqUgDrLqVwm6JrOdU4f8Iyhzd4SywT9pS5r3+rgmzPZ4UgQyS1rv+xiTPoUR8AYAvaLY7S6wYd2J+oxPdwP8WV/xZ3yFSe6IvFIFGENDmxsdQkGFL2mQRElhftuxHXcxMmKZW+rwTrfJZ8gUDvin6/yrKdq7vTqnezd/OCsjko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753352094; c=relaxed/simple; bh=zORcxo3mS6brPEl87DE6MRdiyeVVqdihj/3FCEKbiTM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QSKkmBkuJsCw8rawUtgzccMF6pBcCKZYskU7exrgp0uSDFFQIsyD/Qktm1WSKVDYiWJPh2YUcOosPhnFmXsUu1zLCODN0WB+XR7Y+p9irRDhR3lGq9bvfN0yuoRxN13iXVZzR76YZd/gUnCb357l1NmOKWgKht99NFPXuGWiBdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GDrsj7RG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GDrsj7RG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D83C4CEF4; Thu, 24 Jul 2025 10:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753352093; bh=zORcxo3mS6brPEl87DE6MRdiyeVVqdihj/3FCEKbiTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GDrsj7RGaUKmRFe2YmNRj6/sLBAYZIQjaT4lMyvILBdotUjyjjp9PjzGhfiKnPkhb wdo+ZkLnBwjW8MtDK3qrZT7gMrPKySmosNZNHnzunk3wcRAkiPozCGDIZanfeUFgR1 JifMizySQ87kY9Pm3P9t03L8anZuOJDiarkZFUJ0flEAYrfHrsK18EJ2xknSeOXqRz kOeRWhTUSd9D/VoqhMCSIepkmo4hSmWSqD2ge6ibK6qHY9ZAPPSgQIbGWpUypKRJcv guW2Mq5oK6fCWyBpdzQlM/jYkEZrA0jC4Wt0ykT5pBBgdlJdG5Mk+6GNzR10ZpJps1 lO2wqUbfktYPw== Date: Thu, 24 Jul 2025 11:14:47 +0100 From: Lee Jones To: Alex Elder Cc: lgirdwood@gmail.com, broonie@kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mat.jonczyk@o2.pl, dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com, guodong@riscstar.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/8] mfd: simple-mfd-i2c: specify max_register Message-ID: <20250724101447.GY11056@google.com> References: <20250710175107.1280221-1-elder@riscstar.com> <20250710175107.1280221-3-elder@riscstar.com> <20250723095125.GR11056@google.com> <877dcf99-107e-4d96-8790-6608976d13ca@riscstar.com> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877dcf99-107e-4d96-8790-6608976d13ca@riscstar.com> On Wed, 23 Jul 2025, Alex Elder wrote: > On 7/23/25 4:51 AM, Lee Jones wrote: > > On Thu, 10 Jul 2025, Alex Elder wrote: > > > > > All devices supported by simple MFD use the same 8-bit register 8-bit > > > value regmap configuration. There is an option available for a device > > > to specify a custom configuration, but no existing device uses it. > > > > > > Rather than specify a "full" regmap configuration to change only > > > the max_register value, Lee Jones suggested allowing max_register > > > to be specified in the simple_mfd_data structure. If regmap_config > > > and max_register are both supplied, the max_register field is ignored. > > > > > > Signed-off-by: Alex Elder > > > Suggested-by: Lee Jones > > > --- > > > v8: - Use regmap_config_8r_8v, modifying it if max_register supplied > > > > > > drivers/mfd/simple-mfd-i2c.c | 8 ++++++-- > > > drivers/mfd/simple-mfd-i2c.h | 3 ++- > > > 2 files changed, 8 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > > > index 22159913bea03..5138aa72140b5 100644 > > > --- a/drivers/mfd/simple-mfd-i2c.c > > > +++ b/drivers/mfd/simple-mfd-i2c.c > > > @@ -24,15 +24,16 @@ > > > #include "simple-mfd-i2c.h" > > > -static const struct regmap_config regmap_config_8r_8v = { > > > +static struct regmap_config regmap_config_8r_8v = { > > > .reg_bits = 8, > > > .val_bits = 8, > > > + /* .max_register can be specified in simple_mfd_data */ > > > > Drop this comment please. > > > > > }; > > > static int simple_mfd_i2c_probe(struct i2c_client *i2c) > > > { > > > const struct simple_mfd_data *simple_mfd_data; > > > - const struct regmap_config *regmap_config; > > > + struct regmap_config *regmap_config; > > > struct regmap *regmap; > > > int ret; > > > @@ -43,8 +44,11 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c) > > > regmap_config = ®map_config_8r_8v; > > > else > > > regmap_config = simple_mfd_data->regmap_config; > > > + if (simple_mfd_data && !simple_mfd_data->regmap_config) > > > + regmap_config->max_register = simple_mfd_data->max_register; > > > > If max_register is set in simple_mfd_data, it should take precedence. > > I don't really agree with that. If simple_mfd_data->regmap_config > is provided, why not use the max_register field already available > there? Why would a user add a max_register override to simple_mfd_data if they didn't want to use it? > This is why I said above that I think this feature doesn't add > much value. It provides a second way to specify something, but > in the end it complicates the code more than it's worth. > > The only time this new simple_mfd_data->max_register field seems > to make sense is if it were the only thing provided (without > simple_mfd_data->regmap_config being supplied). In that case, > I see the benefit--a null simple_mfd_data->regmap_config means > use regmap_config_8r_8v, and overlay it with the max_register > value. The new max_register field avoids defining another huge > but mostly empty regmap_config structure. This is your use-case, right? > Anyway, back to your original point: I said in v7 "If both > are specified, the max_register value is ignored" and I think > that's the simplest. Specify one or the other--if you want > to define things in regmap_config, then that's where you add > your max_register. If you like regmap_config_8r_8v but want > to define a max_register value, just provide max_register. > > If you insist, I'll do what you say but before I sent another > version I wanted to explain my reasoning. I hear you and I get what you're saying. I see no use-case where a user would provide both regmap_config AND max_register either. However, I see max_register in simple_mfd_data as an override, so I would like it to take precedence please. > > if (simple_mfd_data && simple_mfd_data->max_register) > > regmap_config->max_register = simple_mfd_data->max_register; > > > > > regmap = devm_regmap_init_i2c(i2c, regmap_config); > > > + regmap_config->max_register = 0; > > > > Does max_register definitely have persistence over subsequent calls? > > It is a global variable. Isn't that how they work? When > it was read-only there was no concern about that, nor about > any possible concurrent access (though I don't think multiple > probes can be using this code at once). > > We could allocate a new one each time instead. > > I think what I offered in v5 was acceptable. If you're > willing to accept that I will be happy to keep discussing > (and implementing) the max_register feature. Yes, I'm inclined to agree. Make the call and I will respect your decision. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C27A4C87FCA for ; Thu, 24 Jul 2025 13:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mEi/IqS4AxJe+L69MIwda86TK+czFl8UkdNE+++SbSg=; b=4PQp8nHGuoatyN 0YkEMMviRyfkF0ePSLdLgfwSbYmsssr4jGfzsUdYnP+5Gp0W+dyYmkJ7+gu9/20OGX5ebfoIDhaWT UPSDZihpmbm4MtR1k3jOGA4bo/l+byv2faV9vChJvNyNfSTZCsMJ+BpQiYR7JP77QkjUTZLnGjfbr pqGLNIQFZmKgPrQMXqVW8y4W1P75228jAwlntISz3PInc0lvr5DHNZOKiL4xgZVhj8LxszJ4Be8S2 1F05GNH2UrcRR4JcPzNuWXQyLl3kbuHeYRe4lARnzN7LQwSKKGJpSTktruKdLxlL/lncHMT1VaEJO Znii8bOGUOVFkgDHX5kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uewN1-00000007Z0x-2XSd; Thu, 24 Jul 2025 13:52:27 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uesyU-00000007BG6-2M2b for linux-riscv@lists.infradead.org; Thu, 24 Jul 2025 10:14:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0EAF64356A; Thu, 24 Jul 2025 10:14:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D83C4CEF4; Thu, 24 Jul 2025 10:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753352093; bh=zORcxo3mS6brPEl87DE6MRdiyeVVqdihj/3FCEKbiTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GDrsj7RGaUKmRFe2YmNRj6/sLBAYZIQjaT4lMyvILBdotUjyjjp9PjzGhfiKnPkhb wdo+ZkLnBwjW8MtDK3qrZT7gMrPKySmosNZNHnzunk3wcRAkiPozCGDIZanfeUFgR1 JifMizySQ87kY9Pm3P9t03L8anZuOJDiarkZFUJ0flEAYrfHrsK18EJ2xknSeOXqRz kOeRWhTUSd9D/VoqhMCSIepkmo4hSmWSqD2ge6ibK6qHY9ZAPPSgQIbGWpUypKRJcv guW2Mq5oK6fCWyBpdzQlM/jYkEZrA0jC4Wt0ykT5pBBgdlJdG5Mk+6GNzR10ZpJps1 lO2wqUbfktYPw== Date: Thu, 24 Jul 2025 11:14:47 +0100 From: Lee Jones To: Alex Elder Cc: lgirdwood@gmail.com, broonie@kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mat.jonczyk@o2.pl, dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com, guodong@riscstar.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/8] mfd: simple-mfd-i2c: specify max_register Message-ID: <20250724101447.GY11056@google.com> References: <20250710175107.1280221-1-elder@riscstar.com> <20250710175107.1280221-3-elder@riscstar.com> <20250723095125.GR11056@google.com> <877dcf99-107e-4d96-8790-6608976d13ca@riscstar.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <877dcf99-107e-4d96-8790-6608976d13ca@riscstar.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250724_031454_641018_FD3C0046 X-CRM114-Status: GOOD ( 38.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyMyBKdWwgMjAyNSwgQWxleCBFbGRlciB3cm90ZToKCj4gT24gNy8yMy8yNSA0OjUx IEFNLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBUaHUsIDEwIEp1bCAyMDI1LCBBbGV4IEVsZGVy IHdyb3RlOgo+ID4gCj4gPiA+IEFsbCBkZXZpY2VzIHN1cHBvcnRlZCBieSBzaW1wbGUgTUZEIHVz ZSB0aGUgc2FtZSA4LWJpdCByZWdpc3RlciA4LWJpdAo+ID4gPiB2YWx1ZSByZWdtYXAgY29uZmln dXJhdGlvbi4gIFRoZXJlIGlzIGFuIG9wdGlvbiBhdmFpbGFibGUgZm9yIGEgZGV2aWNlCj4gPiA+ IHRvIHNwZWNpZnkgYSBjdXN0b20gY29uZmlndXJhdGlvbiwgYnV0IG5vIGV4aXN0aW5nIGRldmlj ZSB1c2VzIGl0Lgo+ID4gPiAKPiA+ID4gUmF0aGVyIHRoYW4gc3BlY2lmeSBhICJmdWxsIiByZWdt YXAgY29uZmlndXJhdGlvbiB0byBjaGFuZ2Ugb25seQo+ID4gPiB0aGUgbWF4X3JlZ2lzdGVyIHZh bHVlLCBMZWUgSm9uZXMgc3VnZ2VzdGVkIGFsbG93aW5nIG1heF9yZWdpc3Rlcgo+ID4gPiB0byBi ZSBzcGVjaWZpZWQgaW4gdGhlIHNpbXBsZV9tZmRfZGF0YSBzdHJ1Y3R1cmUuICBJZiByZWdtYXBf Y29uZmlnCj4gPiA+IGFuZCBtYXhfcmVnaXN0ZXIgYXJlIGJvdGggc3VwcGxpZWQsIHRoZSBtYXhf cmVnaXN0ZXIgZmllbGQgaXMgaWdub3JlZC4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEFs ZXggRWxkZXIgPGVsZGVyQHJpc2NzdGFyLmNvbT4KPiA+ID4gU3VnZ2VzdGVkLWJ5OiBMZWUgSm9u ZXMgPGxlZUBrZXJuZWwub3JnPgo+ID4gPiAtLS0KPiA+ID4gdjg6IC0gVXNlIHJlZ21hcF9jb25m aWdfOHJfOHYsIG1vZGlmeWluZyBpdCBpZiBtYXhfcmVnaXN0ZXIgc3VwcGxpZWQKPiA+ID4gCj4g PiA+ICAgZHJpdmVycy9tZmQvc2ltcGxlLW1mZC1pMmMuYyB8IDggKysrKysrLS0KPiA+ID4gICBk cml2ZXJzL21mZC9zaW1wbGUtbWZkLWkyYy5oIHwgMyArKy0KPiA+ID4gICAyIGZpbGVzIGNoYW5n ZWQsIDggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL21mZC9zaW1wbGUtbWZkLWkyYy5jIGIvZHJpdmVycy9tZmQvc2ltcGxlLW1m ZC1pMmMuYwo+ID4gPiBpbmRleCAyMjE1OTkxM2JlYTAzLi41MTM4YWE3MjE0MGI1IDEwMDY0NAo+ ID4gPiAtLS0gYS9kcml2ZXJzL21mZC9zaW1wbGUtbWZkLWkyYy5jCj4gPiA+ICsrKyBiL2RyaXZl cnMvbWZkL3NpbXBsZS1tZmQtaTJjLmMKPiA+ID4gQEAgLTI0LDE1ICsyNCwxNiBAQAo+ID4gPiAg ICNpbmNsdWRlICJzaW1wbGUtbWZkLWkyYy5oIgo+ID4gPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBy ZWdtYXBfY29uZmlnIHJlZ21hcF9jb25maWdfOHJfOHYgPSB7Cj4gPiA+ICtzdGF0aWMgc3RydWN0 IHJlZ21hcF9jb25maWcgcmVnbWFwX2NvbmZpZ184cl84diA9IHsKPiA+ID4gICAJLnJlZ19iaXRz ID0gOCwKPiA+ID4gICAJLnZhbF9iaXRzID0gOCwKPiA+ID4gKwkvKiAubWF4X3JlZ2lzdGVyIGNh biBiZSBzcGVjaWZpZWQgaW4gc2ltcGxlX21mZF9kYXRhICovCj4gPiAKPiA+IERyb3AgdGhpcyBj b21tZW50IHBsZWFzZS4KPiA+IAo+ID4gPiAgIH07Cj4gPiA+ICAgc3RhdGljIGludCBzaW1wbGVf bWZkX2kyY19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqaTJjKQo+ID4gPiAgIHsKPiA+ID4gICAJ Y29uc3Qgc3RydWN0IHNpbXBsZV9tZmRfZGF0YSAqc2ltcGxlX21mZF9kYXRhOwo+ID4gPiAtCWNv bnN0IHN0cnVjdCByZWdtYXBfY29uZmlnICpyZWdtYXBfY29uZmlnOwo+ID4gPiArCXN0cnVjdCBy ZWdtYXBfY29uZmlnICpyZWdtYXBfY29uZmlnOwo+ID4gPiAgIAlzdHJ1Y3QgcmVnbWFwICpyZWdt YXA7Cj4gPiA+ICAgCWludCByZXQ7Cj4gPiA+IEBAIC00Myw4ICs0NCwxMSBAQCBzdGF0aWMgaW50 IHNpbXBsZV9tZmRfaTJjX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICppMmMpCj4gPiA+ICAgCQly ZWdtYXBfY29uZmlnID0gJnJlZ21hcF9jb25maWdfOHJfOHY7Cj4gPiA+ICAgCWVsc2UKPiA+ID4g ICAJCXJlZ21hcF9jb25maWcgPSBzaW1wbGVfbWZkX2RhdGEtPnJlZ21hcF9jb25maWc7Cj4gPiA+ ICsJaWYgKHNpbXBsZV9tZmRfZGF0YSAmJiAhc2ltcGxlX21mZF9kYXRhLT5yZWdtYXBfY29uZmln KQo+ID4gPiArCQlyZWdtYXBfY29uZmlnLT5tYXhfcmVnaXN0ZXIgPSBzaW1wbGVfbWZkX2RhdGEt Pm1heF9yZWdpc3RlcjsKPiA+IAo+ID4gSWYgbWF4X3JlZ2lzdGVyIGlzIHNldCBpbiBzaW1wbGVf bWZkX2RhdGEsIGl0IHNob3VsZCB0YWtlIHByZWNlZGVuY2UuCj4gCj4gSSBkb24ndCByZWFsbHkg YWdyZWUgd2l0aCB0aGF0LiAgSWYgc2ltcGxlX21mZF9kYXRhLT5yZWdtYXBfY29uZmlnCj4gaXMg cHJvdmlkZWQsIHdoeSBub3QgdXNlIHRoZSBtYXhfcmVnaXN0ZXIgZmllbGQgYWxyZWFkeSBhdmFp bGFibGUKPiB0aGVyZT8KCldoeSB3b3VsZCBhIHVzZXIgYWRkIGEgbWF4X3JlZ2lzdGVyIG92ZXJy aWRlIHRvIHNpbXBsZV9tZmRfZGF0YSBpZiB0aGV5CmRpZG4ndCB3YW50IHRvIHVzZSBpdD8KCj4g VGhpcyBpcyB3aHkgSSBzYWlkIGFib3ZlIHRoYXQgSSB0aGluayB0aGlzIGZlYXR1cmUgZG9lc24n dCBhZGQKPiBtdWNoIHZhbHVlLiAgSXQgcHJvdmlkZXMgYSBzZWNvbmQgd2F5IHRvIHNwZWNpZnkg c29tZXRoaW5nLCBidXQKPiBpbiB0aGUgZW5kIGl0IGNvbXBsaWNhdGVzIHRoZSBjb2RlIG1vcmUg dGhhbiBpdCdzIHdvcnRoLgo+IAo+IFRoZSBvbmx5IHRpbWUgdGhpcyBuZXcgc2ltcGxlX21mZF9k YXRhLT5tYXhfcmVnaXN0ZXIgZmllbGQgc2VlbXMKPiB0byBtYWtlIHNlbnNlIGlzIGlmIGl0IHdl cmUgdGhlIG9ubHkgdGhpbmcgcHJvdmlkZWQgKHdpdGhvdXQKPiBzaW1wbGVfbWZkX2RhdGEtPnJl Z21hcF9jb25maWcgYmVpbmcgc3VwcGxpZWQpLiAgSW4gdGhhdCBjYXNlLAo+IEkgc2VlIHRoZSBi ZW5lZml0LS1hIG51bGwgc2ltcGxlX21mZF9kYXRhLT5yZWdtYXBfY29uZmlnIG1lYW5zCj4gdXNl IHJlZ21hcF9jb25maWdfOHJfOHYsIGFuZCBvdmVybGF5IGl0IHdpdGggdGhlIG1heF9yZWdpc3Rl cgo+IHZhbHVlLiAgVGhlIG5ldyBtYXhfcmVnaXN0ZXIgZmllbGQgYXZvaWRzIGRlZmluaW5nIGFu b3RoZXIgaHVnZQo+IGJ1dCBtb3N0bHkgZW1wdHkgcmVnbWFwX2NvbmZpZyBzdHJ1Y3R1cmUuCgpU aGlzIGlzIHlvdXIgdXNlLWNhc2UsIHJpZ2h0PwoKPiBBbnl3YXksIGJhY2sgdG8geW91ciBvcmln aW5hbCBwb2ludDogIEkgc2FpZCBpbiB2NyAiSWYgYm90aAo+IGFyZSBzcGVjaWZpZWQsIHRoZSBt YXhfcmVnaXN0ZXIgdmFsdWUgaXMgaWdub3JlZCIgYW5kIEkgdGhpbmsKPiB0aGF0J3MgdGhlIHNp bXBsZXN0LiAgU3BlY2lmeSBvbmUgb3IgdGhlIG90aGVyLS1pZiB5b3Ugd2FudAo+IHRvIGRlZmlu ZSB0aGluZ3MgaW4gcmVnbWFwX2NvbmZpZywgdGhlbiB0aGF0J3Mgd2hlcmUgeW91IGFkZAo+IHlv dXIgbWF4X3JlZ2lzdGVyLiAgSWYgeW91IGxpa2UgcmVnbWFwX2NvbmZpZ184cl84diBidXQgd2Fu dAo+IHRvIGRlZmluZSBhIG1heF9yZWdpc3RlciB2YWx1ZSwganVzdCBwcm92aWRlIG1heF9yZWdp c3Rlci4KPiAKPiBJZiB5b3UgaW5zaXN0LCBJJ2xsIGRvIHdoYXQgeW91IHNheSBidXQgYmVmb3Jl IEkgc2VudCBhbm90aGVyCj4gdmVyc2lvbiBJIHdhbnRlZCB0byBleHBsYWluIG15IHJlYXNvbmlu Zy4KCkkgaGVhciB5b3UgYW5kIEkgZ2V0IHdoYXQgeW91J3JlIHNheWluZy4KCkkgc2VlIG5vIHVz ZS1jYXNlIHdoZXJlIGEgdXNlciB3b3VsZCBwcm92aWRlIGJvdGggcmVnbWFwX2NvbmZpZyBBTkQK bWF4X3JlZ2lzdGVyIGVpdGhlci4gIEhvd2V2ZXIsIEkgc2VlIG1heF9yZWdpc3RlciBpbiBzaW1w bGVfbWZkX2RhdGEgYXMKYW4gb3ZlcnJpZGUsIHNvIEkgd291bGQgbGlrZSBpdCB0byB0YWtlIHBy ZWNlZGVuY2UgcGxlYXNlLgoKPiA+IGlmIChzaW1wbGVfbWZkX2RhdGEgJiYgc2ltcGxlX21mZF9k YXRhLT5tYXhfcmVnaXN0ZXIpCj4gPiAJcmVnbWFwX2NvbmZpZy0+bWF4X3JlZ2lzdGVyID0gc2lt cGxlX21mZF9kYXRhLT5tYXhfcmVnaXN0ZXI7Cj4gPiAKPiA+ID4gICAJcmVnbWFwID0gZGV2bV9y ZWdtYXBfaW5pdF9pMmMoaTJjLCByZWdtYXBfY29uZmlnKTsKPiA+ID4gKwlyZWdtYXBfY29uZmln LT5tYXhfcmVnaXN0ZXIgPSAwOwo+ID4gCj4gPiBEb2VzIG1heF9yZWdpc3RlciBkZWZpbml0ZWx5 IGhhdmUgcGVyc2lzdGVuY2Ugb3ZlciBzdWJzZXF1ZW50IGNhbGxzPwo+IAo+IEl0IGlzIGEgZ2xv YmFsIHZhcmlhYmxlLiAgSXNuJ3QgdGhhdCBob3cgdGhleSB3b3JrPyAgV2hlbgo+IGl0IHdhcyBy ZWFkLW9ubHkgdGhlcmUgd2FzIG5vIGNvbmNlcm4gYWJvdXQgdGhhdCwgbm9yIGFib3V0Cj4gYW55 IHBvc3NpYmxlIGNvbmN1cnJlbnQgYWNjZXNzICh0aG91Z2ggSSBkb24ndCB0aGluayBtdWx0aXBs ZQo+IHByb2JlcyBjYW4gYmUgdXNpbmcgdGhpcyBjb2RlIGF0IG9uY2UpLgo+IAo+IFdlIGNvdWxk IGFsbG9jYXRlIGEgbmV3IG9uZSBlYWNoIHRpbWUgaW5zdGVhZC4KPiAKPiBJIHRoaW5rIHdoYXQg SSBvZmZlcmVkIGluIHY1IHdhcyBhY2NlcHRhYmxlLiAgSWYgeW91J3JlCj4gd2lsbGluZyB0byBh Y2NlcHQgdGhhdCBJIHdpbGwgYmUgaGFwcHkgdG8ga2VlcCBkaXNjdXNzaW5nCj4gKGFuZCBpbXBs ZW1lbnRpbmcpIHRoZSBtYXhfcmVnaXN0ZXIgZmVhdHVyZS4KClllcywgSSdtIGluY2xpbmVkIHRv IGFncmVlLgoKTWFrZSB0aGUgY2FsbCBhbmQgSSB3aWxsIHJlc3BlY3QgeW91ciBkZWNpc2lvbi4K Ci0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcmlzY3YK