From: Simon Horman <horms@kernel.org>
To: Jimmy Assarsson <extja@kvaser.com>
Cc: linux-can@vger.kernel.org,
Jimmy Assarsson <jimmyassarsson@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 08/10] can: kvaser_pciefd: Expose device firmware version via devlink info_get()
Date: Thu, 24 Jul 2025 14:52:24 +0100 [thread overview]
Message-ID: <20250724135224.GA1266901@horms.kernel.org> (raw)
In-Reply-To: <20250724073021.8-9-extja@kvaser.com>
On Thu, Jul 24, 2025 at 09:30:19AM +0200, Jimmy Assarsson wrote:
...
> diff --git a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
> index 8145d25943de..4e4550115368 100644
> --- a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
> +++ b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
> @@ -4,7 +4,33 @@
> * Copyright (C) 2025 KVASER AB, Sweden. All rights reserved.
> */
>
> +#include "kvaser_pciefd.h"
> +
> #include <net/devlink.h>
Hi Jimmy,
Please consider squashing the two-line change above into
the previous patch in this series to avoid the following
transient Sparse warning.
.../kvaser_pciefd_devlink.c:9:26: warning: symbol 'kvaser_pciefd_devlink_ops' was not declared. Should it be static?
Thanks!
next prev parent reply other threads:[~2025-07-24 13:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 7:30 [PATCH v3 00/10] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 01/10] can: kvaser_pciefd: Add support to control CAN LEDs on device Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 02/10] can: kvaser_pciefd: Add support for ethtool set_phys_id() Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 03/10] can: kvaser_pciefd: Add intermediate variable for device struct in probe() Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 04/10] can: kvaser_pciefd: Store the different firmware version components in a struct Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 05/10] can: kvaser_pciefd: Store device channel index Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 06/10] can: kvaser_pciefd: Split driver into C-file and header-file Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 07/10] can: kvaser_pciefd: Add devlink support Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 08/10] can: kvaser_pciefd: Expose device firmware version via devlink info_get() Jimmy Assarsson
2025-07-24 13:52 ` Simon Horman [this message]
2025-07-25 12:39 ` Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 09/10] can: kvaser_pciefd: Add devlink port support Jimmy Assarsson
2025-07-24 7:30 ` [PATCH v3 10/10] Documentation: devlink: add devlink documentation for the kvaser_pciefd driver Jimmy Assarsson
2025-07-24 11:10 ` [PATCH v3 00/10] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Paolo Abeni
2025-07-25 3:05 ` Vincent Mailhol
2025-07-25 8:51 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724135224.GA1266901@horms.kernel.org \
--to=horms@kernel.org \
--cc=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.