From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next] selftests: net: Skip test if IPv6 is not configured
Date: Thu, 24 Jul 2025 18:24:27 -0700 [thread overview]
Message-ID: <20250724182427.5ece92e8@kernel.org> (raw)
In-Reply-To: <20250723-netcons_test_ipv6-v1-1-41c9092f93f9@debian.org>
On Wed, 23 Jul 2025 10:35:06 -0700 Breno Leitao wrote:
> Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check
> whether IPv6 is enabled by verifying the existence of
> `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole
> tests. If the file does not exist, the script will skip the test with an
> appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
>
> This prevents the test to misbehave if IPv6 is not configured.
IDK. I think this is related to some of the recent patches?
The context would be helpful in the commit message.
Otherwise, as networking people, I think we are obligated
to respond with hostility to "IPv6 may not be enabled"..
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-25 1:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 17:35 [PATCH net-next] selftests: net: Skip test if IPv6 is not configured Breno Leitao
2025-07-24 20:13 ` Simon Horman
2025-07-25 1:24 ` Jakub Kicinski [this message]
2025-07-25 8:11 ` Breno Leitao
2025-07-25 20:47 ` Willem de Bruijn
2025-07-25 20:58 ` Jakub Kicinski
2025-07-25 21:11 ` Willem de Bruijn
2025-07-25 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724182427.5ece92e8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.