From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F128822AE5D for ; Thu, 24 Jul 2025 19:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753385477; cv=none; b=Im3Z7Sh/Q/V98QQIELopcEubZCYGJaVLf0UyH2EfI7IexVEgE0BU1o+60azTcE7A7RXUBXjLbemqX6x/npTkX6X3e5IUzPJwx/aYwlBMgRpPxi2IjZmwMaVUS2C/zBvwygNexEgx7ZEE+2LGNULvbo/TfzrEjGRrLAnCRnzYxno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753385477; c=relaxed/simple; bh=DSmvlNxXzNmqa0Qu8i3JUhrsjcQBmSjxoYBtvP/PJA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1jlKvtFT3gvm3sYdC+5sdcxLIeOEl2+GJCQTaJIUah9yjqvuap1SMLmU1Hn59bgCStCGpw4tJtWC/CpteRM3Yv4ZSAzi0bCXZe20kLe9jvO2E/wzBOLzXrZv+n0akJRy5j6Ya1EUxq00GgNUbMCe6k6JkOoteu7ddfF4LZU+xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NbeLtJt/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NbeLtJt/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C074C4CEF1; Thu, 24 Jul 2025 19:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753385476; bh=DSmvlNxXzNmqa0Qu8i3JUhrsjcQBmSjxoYBtvP/PJA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NbeLtJt/NlnNEnIXyC/XHaNowU0VVdWtf/XkhRBxpV3NW0CJ8eIbuUCUSo8ln1rED tdPluHTSYFlLweYaGuTyiG83jT9P43rxYmwY4liZ64K/Nou2I+oNO2Ps1u/Q3m+KyP ZgACxr9hHpfLVLCojX8l0SyOtDKtyKTl5EwAHh2DZoxv8HaxKkNa9ymJwEGY6Pv10T +gsvFb/NN3MNfuat1wOZuP/yOTK58j0qnMu1fqA9VjaTjJd9EmouhlE3uJHC4e3sAI 1Bjzqv9Zbd3jLx9zZchIrmEPI1F7ldN74FG0GT8iYuEUBwyjDN2MFhDNp9Iu4LHZkF xs3idSfXy9gwA== From: Mike Snitzer To: Chuck Lever , Jeff Layton , Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: [PATCH v5 09/13] nfs/localio: add nfsd_file_dio_alignment Date: Thu, 24 Jul 2025 15:30:58 -0400 Message-ID: <20250724193102.65111-10-snitzer@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250724193102.65111-1-snitzer@kernel.org> References: <20250724193102.65111-1-snitzer@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mike Snitzer And use it to avoid issuing misaligned IO using O_DIRECT. Signed-off-by: Mike Snitzer --- fs/nfs/localio.c | 26 ++++++++++++++++++++++---- fs/nfsd/localio.c | 11 +++++++++++ include/linux/nfslocalio.h | 2 ++ 3 files changed, 35 insertions(+), 4 deletions(-) diff --git a/fs/nfs/localio.c b/fs/nfs/localio.c index 0b54f01299d2..0c48db38f74f 100644 --- a/fs/nfs/localio.c +++ b/fs/nfs/localio.c @@ -322,12 +322,10 @@ nfs_local_iocb_alloc(struct nfs_pgio_header *hdr, return NULL; } + init_sync_kiocb(&iocb->kiocb, file); if (localio_O_DIRECT_semantics && - test_bit(NFS_IOHDR_ODIRECT, &hdr->flags)) { - iocb->kiocb.ki_filp = file; + test_bit(NFS_IOHDR_ODIRECT, &hdr->flags)) iocb->kiocb.ki_flags = IOCB_DIRECT; - } else - init_sync_kiocb(&iocb->kiocb, file); iocb->kiocb.ki_pos = hdr->args.offset; iocb->hdr = hdr; @@ -346,6 +344,26 @@ nfs_local_iter_init(struct iov_iter *i, struct nfs_local_kiocb *iocb, int dir) hdr->args.count + hdr->args.pgbase); if (hdr->args.pgbase != 0) iov_iter_advance(i, hdr->args.pgbase); + + if (iocb->kiocb.ki_flags & IOCB_DIRECT) { + u32 nf_dio_mem_align, nf_dio_offset_align, nf_dio_read_offset_align; + /* Verify the IO is DIO-aligned as required */ + nfs_to->nfsd_file_dio_alignment(iocb->localio, &nf_dio_mem_align, + &nf_dio_offset_align, + &nf_dio_read_offset_align); + if (dir == READ) + nf_dio_offset_align = nf_dio_read_offset_align; + /* direct I/O must be aligned to device logical sector size */ + if (nf_dio_mem_align && nf_dio_offset_align && + (((hdr->args.offset | hdr->args.count) & (nf_dio_offset_align-1)) == 0) && + iov_iter_is_aligned(i, nf_dio_mem_align - 1, + nf_dio_offset_align - 1)) + return 0; + + /* Fallback to using buffered for this misaligned IO */ + iocb->kiocb.ki_flags &= ~IOCB_DIRECT; + iocb->kiocb.ki_filp->f_flags &= ~O_DIRECT; + } } static void diff --git a/fs/nfsd/localio.c b/fs/nfsd/localio.c index 269fa9391dc4..be710d809a3b 100644 --- a/fs/nfsd/localio.c +++ b/fs/nfsd/localio.c @@ -117,12 +117,23 @@ nfsd_open_local_fh(struct net *net, struct auth_domain *dom, return localio; } +static void nfsd_file_dio_alignment(struct nfsd_file *nf, + u32 *nf_dio_mem_align, + u32 *nf_dio_offset_align, + u32 *nf_dio_read_offset_align) +{ + *nf_dio_mem_align = nf->nf_dio_mem_align; + *nf_dio_offset_align = nf->nf_dio_offset_align; + *nf_dio_read_offset_align = nf->nf_dio_read_offset_align; +} + static const struct nfsd_localio_operations nfsd_localio_ops = { .nfsd_net_try_get = nfsd_net_try_get, .nfsd_net_put = nfsd_net_put, .nfsd_open_local_fh = nfsd_open_local_fh, .nfsd_file_put_local = nfsd_file_put_local, .nfsd_file_file = nfsd_file_file, + .nfsd_file_dio_alignment = nfsd_file_dio_alignment, }; void nfsd_localio_ops_init(void) diff --git a/include/linux/nfslocalio.h b/include/linux/nfslocalio.h index 59ea90bd136b..3d91043254e6 100644 --- a/include/linux/nfslocalio.h +++ b/include/linux/nfslocalio.h @@ -64,6 +64,8 @@ struct nfsd_localio_operations { const fmode_t); struct net *(*nfsd_file_put_local)(struct nfsd_file __rcu **); struct file *(*nfsd_file_file)(struct nfsd_file *); + void (*nfsd_file_dio_alignment)(struct nfsd_file *, + u32 *, u32 *, u32 *); } ____cacheline_aligned; extern void nfsd_localio_ops_init(void); -- 2.44.0