All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: Crediting test authors
Date: Fri, 25 Jul 2025 10:15:32 -0700	[thread overview]
Message-ID: <20250725101532.5a3bf75b@kernel.org> (raw)
In-Reply-To: <aIOzMLPiC8gN5t2Y@finisterre.sirena.org.uk>

On Fri, 25 Jul 2025 17:39:12 +0100 Mark Brown wrote:
> On Fri, Jul 25, 2025 at 08:00:23AM -0700, Jakub Kicinski wrote:
> 
> > Does anyone have ideas about crediting test authors or tests for bugs
> > discovered?  We increasingly see situations where someone adds a test
> > then our subsystem CI uncovers a (1 in a 100 runs) bug using that test.  
> 
> > Using reported-by doesn't feel right. But credit should go to the
> > person who wrote the test. Is anyone else having this dilemma?  
> 
> Usually I'd do a reported-by for whoever actually looked at the test
> system, triaged the issue and reported it.  Trying to credit test
> authorship separately to the testsuite gets cumbersome over time, tests
> get updated over time for a range of reasons (toolchain updates, adding
> more coverage, improvements in the testsuite's frameworks...) so it's
> often not just a single person.  Hopefully the testsuite is keeping
> track of things well enough so mentioning the test will point people in
> the right direction.

Ack, it does get murky overtime. Also with pre-commit testing there
usually wouldn't even be a bug in the tree to credit fixing. 

I guess we just had a lucky(?) string of very clear cut cases where
a good selftest led the maintainer noticing a crash in the CI, and 
fixing something.

      reply	other threads:[~2025-07-25 17:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 15:00 Crediting test authors Jakub Kicinski
2025-07-25 15:26 ` Theodore Ts'o
2025-07-25 16:38 ` dan.j.williams
2025-07-25 17:20   ` Jakub Kicinski
2025-07-25 17:20     ` Jakub Kicinski
2025-07-25 18:37     ` dan.j.williams
2025-07-26 21:44       ` Mark Brown
2025-07-31 14:30         ` Gustavo Padovan
2025-07-25 16:39 ` Mark Brown
2025-07-25 17:15   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250725101532.5a3bf75b@kernel.org \
    --to=kuba@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.