From: Jakub Kicinski <kuba@kernel.org>
To: Vishal Badole <Vishal.Badole@amd.com>
Cc: <Shyam-sundar.S-k@amd.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH net-next] amd-xgbe: Configure and retrieve 'tx-usecs' for Tx coalescing
Date: Fri, 25 Jul 2025 18:07:27 -0700 [thread overview]
Message-ID: <20250725180727.615d1612@kernel.org> (raw)
In-Reply-To: <20250719072608.4048494-1-Vishal.Badole@amd.com>
On Sat, 19 Jul 2025 12:56:08 +0530 Vishal Badole wrote:
> + /* Check if both tx_usecs and tx_frames are set to 0 simultaneously */
> + if (!tx_usecs && !tx_frames) {
> + netdev_err(netdev,
> + "tx_usecs and tx_frames must not be 0 together\n");
> + return -EINVAL;
> + }
> +
> /* Check the bounds of values for Tx */
> + if (tx_usecs > XGMAC_MAX_COAL_TX_TICK) {
> + netdev_err(netdev, "tx-usecs is limited to %d usec\n",
> + XGMAC_MAX_COAL_TX_TICK);
> + return -EINVAL;
> + }
Please use extack to report the error to the user rather than system
logs.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-26 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 7:26 [RESEND PATCH net-next] amd-xgbe: Configure and retrieve 'tx-usecs' for Tx coalescing Vishal Badole
2025-07-19 15:16 ` Vadim Fedorenko
2025-07-20 18:28 ` Badole, Vishal
2025-07-20 21:35 ` Vadim Fedorenko
2025-07-25 8:59 ` Badole, Vishal
2025-07-26 1:07 ` Jakub Kicinski [this message]
2025-07-26 11:08 ` Badole, Vishal
2025-08-01 1:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725180727.615d1612@kernel.org \
--to=kuba@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.