From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EA3215175; Sat, 26 Jul 2025 20:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753562915; cv=none; b=e2TpIsoYK7A4GTG5HxNLnVosNPrqnGUMJD4Jmhjob+51beU9iWfgmnCD/AeEiCzbPGecgRW9JSvjMKnhFoTeluzn2u6s6HOMMwxtmjlaUTFN5g2vwm7BwTZZln93sJ93QR9/zJfJzn6/mg0lXxd+ZXAtoThkKBOKZMb37i/+50c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753562915; c=relaxed/simple; bh=bU+4aFNSARke7Rm+3vDlswJMu5NtAU+xV7xo2Lk+CW8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DtJGWDcaPZK6oa/874tYGyu3dvjaw47slTttowSUKSw2ycYiM/RgSNK7OyNOIq8Pb/3Ie6h5FuWMkLXZQhqJBGQBPaq5zF7nGwY/j2eiluf7CCzNnppNz4W7Z7R/Eeezo3TJS7luNxt8PkOK0XsjCYgXJbyalS4D2I6gh3BNrNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hfgOr/v1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hfgOr/v1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACAFC4CEED; Sat, 26 Jul 2025 20:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753562914; bh=bU+4aFNSARke7Rm+3vDlswJMu5NtAU+xV7xo2Lk+CW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hfgOr/v1cU8iQKAqQr9RiJro70NI+tbPO8epuBLnp9p0T8u9W9YSjjWTpPfCPgOcS QaGZCiRsVQVvHplc5W4oLtOic2YBpSDryZWRvlYRai65SPmrR1f+BK4FY3V3P7eetV Z82fRY5G+aEmglZKANsDHHmNzuGSVs9yWDyjlays2haLFkyX+hTkeJ1qxsAATg+y8g EK8Gl8ZwMi3MSPjLLGiaXHpP3IWlnvfY/yFsPVaLxVnfweUikh7X8ul85PkueORCnn mo2NVdbPywxxJt2PFCK9mYKkX/RrCYm4YOZzNiHbeyzldVTceE2Uz2sVKd+OD9cmif HcgIPD9eZeCyg== Date: Sat, 26 Jul 2025 21:48:28 +0100 From: Simon Horman To: Johan Hovold Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yangbo Lu Subject: Re: [PATCH 1/5] net: dpaa: fix device leak when querying time stamp info Message-ID: <20250726204828.GQ1367887@horms.kernel.org> References: <20250725171213.880-1-johan@kernel.org> <20250725171213.880-2-johan@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250725171213.880-2-johan@kernel.org> On Fri, Jul 25, 2025 at 07:12:09PM +0200, Johan Hovold wrote: > Make sure to drop the reference to the ptp device taken by > of_find_device_by_node() when querying the time stamping capabilities. > > Note that holding a reference to the ptp device does not prevent its > driver data from going away. > > Fixes: 17ae0b0ee9db ("dpaa_eth: add the get_ts_info interface for ethtool") > Cc: stable@vger.kernel.org # 4.19 > Cc: Yangbo Lu > Signed-off-by: Johan Hovold Reviewed-by: Simon Horman