From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A6EAC83F17 for ; Mon, 28 Jul 2025 10:57:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 733A460265; Mon, 28 Jul 2025 12:56:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 733A460265 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1753700220; bh=101L7ZMoSdx2x9v7q29U8ZPnWqt4303aTxdUTH++2CM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=d7nwDJpBb9iJe5L7n3LE2rYw6GYx7u5m3E/q51dfNK/W95ZyFCivcwgz307wETC+r UVxbVW2QmEZjhDmO+UPQlpsfpPwd7+doi8JrhoQHIRgBSVegHFDbujZRNk31cPKFQL A8leBKNuroTE9mSB/GcOPtkOF/4ncB2nhaNlLLhs= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6708F805D2; Mon, 28 Jul 2025 12:56:29 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9C58EF805D3; Mon, 28 Jul 2025 12:56:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DE8A1F8026A; Mon, 28 Jul 2025 12:52:50 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5C70F8011B for ; Mon, 28 Jul 2025 12:52:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5C70F8011B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=VVhjyRtq Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E86F75C58F5; Mon, 28 Jul 2025 10:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 104F6C4CEF6; Mon, 28 Jul 2025 10:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1753699964; bh=101L7ZMoSdx2x9v7q29U8ZPnWqt4303aTxdUTH++2CM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVhjyRtqTgbkzAUekyOkQGQFGUg5z16o5i12+pFbCbx/0LVPHsgx7W9aGOArJEi4Q EPgmiUJ57BlnIvLqez78I5LfB1HN8YgxM8EqljDSiVO29l0BFtADF8NHb2MsoehUIk tki5nf+NyxOdkQispBBGxM5nVLYnQqZDMmOjlGi8= Date: Mon, 28 Jul 2025 12:52:41 +0200 From: Greg KH To: Venkata Prasad Potturu Cc: broonie@kernel.org, alsa-devel@alsa-project.org, Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, syed.sabakareem@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Mario Limonciello , Peter Zijlstra , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: Re: [PATCH] ASoC: amd: acp: Adjust pdm dmic gain using module parameter Message-ID: <2025072809-spookily-grip-3c2f@gregkh> References: <20250728094243.3824450-1-venkataprasad.potturu@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250728094243.3824450-1-venkataprasad.potturu@amd.com> Message-ID-Hash: DBINGLT65HH2IFVCORRZ6Y34QMYB6HQ7 X-Message-ID-Hash: DBINGLT65HH2IFVCORRZ6Y34QMYB6HQ7 X-MailFrom: gregkh@linuxfoundation.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 28, 2025 at 03:12:27PM +0530, Venkata Prasad Potturu wrote: > Adjust pdm dimc gain value using module param. > In case of regressions for any users that the new pdm_gain value is > too high and for additional debugging, introduce a module parameter > that would let them configure it. > > This parameter should be removed in the future: > * If it's determined that the parameter is not needed, just hardcode > the correct value as before > * If users do end up using it to debug and report different values > we should introduce a config knob that can have policy set by ucm. Note, you can not break a user/kernel api like this once you introduce it, so be VERY careful (yet another reason for it to NOT be a module parameter...)