From: Oleg Nesterov <oleg@redhat.com>
To: fan.yu9@zte.com.cn, Andrew Morton <akpm@linux-foundation.org>
Cc: tglx@linutronix.de, frederic@kernel.org, peterz@infradead.org,
brauner@kernel.org, iro@zeniv.linux.org.uk,
joel.granados@kernel.org, lorenzo.stoakes@oracle.com,
linux-kernel@vger.kernel.org, xu.xin16@zte.com.cn,
yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next] signal: Remove outdated __send_signal references in? do_notify_parent
Date: Mon, 28 Jul 2025 11:54:05 +0200 [thread overview]
Message-ID: <20250728095405.GA25567@redhat.com> (raw)
In-Reply-To: <202507281624542763Kn377WvUMXlKHVJUdNjA@zte.com.cn>
On 07/28, fan.yu9@zte.com.cn wrote:
>
> From: Fan Yu <fan.yu9@zte.com.cn>
>
> The function __send_signal was renamed to __send_signal_locked in
> commit 157cc18122b4 ("signal: Rename send_signal send_signal_locked"),
> making the existing comments in do_notify_parent obsolete.
>
> This patch removes these outdated references to maintain code clarity
> and prevent confusion about the current implementation.
>
> Signed-off-by: Fan Yu <fan.yu9@zte.com.cn>
> ---
> kernel/signal.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index e2c928de7d2c..30a52d884f87 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2251,10 +2251,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
> if (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN)
> sig = 0;
> }
> - /*
> - * Send with __send_signal as si_pid and si_uid are in the
> - * parent's namespaces.
> - */
> +
> if (valid_signal(sig) && sig)
> __send_signal_locked(sig, &info, tsk->parent, PIDTYPE_TGID, false);
> __wake_up_parent(tsk, tsk->parent);
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2025-07-28 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 8:24 [PATCH linux-next] signal: Remove outdated __send_signal references in do_notify_parent fan.yu9
2025-07-28 9:54 ` Oleg Nesterov [this message]
2025-07-28 14:58 ` Thomas Gleixner
2025-07-28 15:58 ` Oleg Nesterov
2025-07-29 7:04 ` fan.yu9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728095405.GA25567@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=fan.yu9@zte.com.cn \
--cc=frederic@kernel.org \
--cc=iro@zeniv.linux.org.uk \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.