Re: [Buildroot] [PATCH 1/2] package/cjson: fix cmake 4 compatibility

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/cjson: fix cmake 4 compatibility
Date: Mon, 28 Jul 2025 17:51:25 +0200	[thread overview]
Message-ID: <20250728175125.6f2cb668@windsurf> (raw)
In-Reply-To: <20250725-cmake4-v1-1-156f29160913@bootlin.com>

Hello Benoît,

On Fri, 25 Jul 2025 17:22:50 +0200
Benoît Monin <benoit.monin@bootlin.com> wrote:

> Add a patch fixing cmake 4 compatibility, found in upstream pull
> request #935.
> 
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
>  .../0001-make_compatible_with_cmake_4.0.patch      | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/package/cjson/0001-make_compatible_with_cmake_4.0.patch b/package/cjson/0001-make_compatible_with_cmake_4.0.patch
> new file mode 100644
> index 0000000000000000000000000000000000000000..f44dae45485e8a9868fdedfd5729789c260d2cf3
> --- /dev/null
> +++ b/package/cjson/0001-make_compatible_with_cmake_4.0.patch
> @@ -0,0 +1,33 @@
> +From 58bc7c823c2e39f1a626ec4da86952bc6819bd6b Mon Sep 17 00:00:00 2001
> +From: Markus Vieth <mvieth@techfak.uni-bielefeld.de>
> +Date: Sun, 30 Mar 2025 11:12:07 +0200
> +Subject: [PATCH] Make compatible with CMake 4.0 When trying to build with
> + CMake 4.0, the following error is shown:
> +
> +CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
> +  Compatibility with CMake < 3.5 has been removed from CMake.
> +
> +  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
> +  to tell CMake that the project requires at least <min> but has been updated
> +  to work with policies introduced by <max> or earlier.
> +
> +  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
> +
> +This change raises the minimum required CMake version to 3.5 and thus makes the project compatible with CMake 4.0
> +
> +Upstream: https://github.com/DaveGamble/cJSON/pull/935

Thanks for this patch. We have a policy in Buildroot that all patches
that are integrated into packages should be Signed-off-by by whoever
adds the patch into Buildroot, in this case: you.

Could you resend your series with your SoB line added to the patches
themselves?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot