Re: [meta-ti][scarthgap/master][PATCH 3/3] wic: sdimage-2part-efi: Remove 3 second menu delay

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Jul 28, 2025 at 03:33:23PM -0500, Ryan Eatmon wrote:
> 
> 
> On 7/28/2025 3:20 PM, Khem Raj via lists.yoctoproject.org wrote:
> >On Mon, Jul 28, 2025 at 12:45 PM Denys Dmytriyenko <denis@denix.org> wrote:
> >>
> >>On Mon, Jul 28, 2025 at 11:28:36AM -0700, Khem Raj wrote:
> >>>On Mon, Jul 28, 2025 at 11:25 AM Denys Dmytriyenko via
> >>>lists.yoctoproject.org <denis=denix.org@lists.yoctoproject.org> wrote:
> >>>>
> >>>>On Mon, Jul 28, 2025 at 11:54:37AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> >>>>>For all our platforms booting with EFI there is only one option today.
> >>>>>The timeout gives the user 3 seconds to choose a different option, but
> >>>>>as there is only one, this just causes a needless 3 second delay in
> >>>>>boot time. Remove this delay and boot the only option immediately.
> >>>>>If we ever have more than one option we can always add this back.
> >>>>
> >>>>Well, menu delay in grub is not only used for selecting among available
> >>>>predefined options, but also for interactively editing the command line
> >>>>on the fly before booting.
> >>>>
> >>>
> >>>for development, this sounds good, for production not so much.
> >>
> >>Sure. And we also disable e.g. U-boot boot prompt delay all the time for our
> >>customers during production hardening stage, among many other similar items.
> >>But it is done for the final product - I don't think it should be done in a
> >>generic BSP layer that many use for development.
> >
> >Right, it could be documented somewhere in README or some such would help
> >the consumers of the layer.
> 
> Is there already something in the system that we could use to drive
> a variable that we can stick into the file?  Like
> EXTRA_IMAGE_FEATURES?  I know there used to be a debug-tweaks that
> got broken out into multiple features.  Maybe create a new one?
> 
> TI_WKS_TIMEOUT = '${@bb.utils.contains("IMAGE_FEATURES",
> "wks-debug-timeout", "3", "0 ",d)}'

Should probably make it more generic, not wks. I'd imagine it can be shared 
for U-boot and EFI/GRUB, so maybe bootloader-timeout or something?


> bootloader --timeout=${TI_WKS_TIMEOUT} --append="rootfstype=ext4
> rootwait ${TI_WKS_BOOTLOADER_APPEND}"
> 
> 
> Would that work?
> 
> 
> >>
> >>
> >>>>>Signed-off-by: Andrew Davis <afd@ti.com>
> >>>>>---
> >>>>>  meta-ti-bsp/wic/sdimage-2part-efi.wks.in | 2 +-
> >>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>>diff --git a/meta-ti-bsp/wic/sdimage-2part-efi.wks.in b/meta-ti-bsp/wic/sdimage-2part-efi.wks.in
> >>>>>index 7252411c..c1089762 100644
> >>>>>--- a/meta-ti-bsp/wic/sdimage-2part-efi.wks.in
> >>>>>+++ b/meta-ti-bsp/wic/sdimage-2part-efi.wks.in
> >>>>>@@ -3,6 +3,6 @@
> >>>>>  # supports EFI.  Boot files are located in the first vfat partition with extra
> >>>>>  # reserved space.  We cannot use a GPT here.
> >>>>>
> >>>>>-bootloader --timeout=3 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
> >>>>>+bootloader --timeout=0 --append="rootfstype=ext4 rootwait ${TI_WKS_BOOTLOADER_APPEND}"
> >>>>>  part --source bootimg-efi --sourceparams="loader=${EFI_PROVIDER}" --fstype=vfat --label boot --active --align 1024 --use-uuid --fixed-size 128M
> >>>>>  part / --source rootfs --fstype=ext4 --label root --align 1024 --use-uuid
> >>>>>--
> >>>>>2.39.2
> >>>>>
> >>>>>
> >>>>>-=-=-=-=-=-=-=-=-=-=-=-
> >>>>>Links: You receive all messages sent to this group.
> >>>>>View/Reply Online (#18848): https://lists.yoctoproject.org/g/meta-ti/message/18848
> >>>>>Mute This Topic: https://lists.yoctoproject.org/mt/114416911/6551054
> >>>>>Group Owner: meta-ti+owner@lists.yoctoproject.org
> >>>>>Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
> >>>>>-=-=-=-=-=-=-=-=-=-=-=-
> >>>>>