From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: [chrome-os:chromeos-6.6 320/320] drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1896:6-32: opportunity for str_on_off(rtwdev -> is_tssi_mode [ path ])
Date: Mon, 28 Jul 2025 23:19:20 +0800 [thread overview]
Message-ID: <202507282341.drTGfLWA-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com
Hi Ping-Ke,
First bad commit (maybe != root cause):
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head: 32c99cd5db842851e5acd8b583738b7848afc5fd
commit: 3d6c0d0fe1eac2100870a57c34988bb47ac181ff [320/320] UPSTREAM: wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig
:::::: branch date: 13 hours ago
:::::: commit date: 2 weeks ago
config: x86_64-randconfig-102-20250728 (https://download.01.org/0day-ci/archive/20250728/202507282341.drTGfLWA-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202507282341.drTGfLWA-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1896:6-32: opportunity for str_on_off(rtwdev -> is_tssi_mode [ path ])
>> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1897:6-21: opportunity for str_on_off(rtwdev -> dbcc_en)
vim +1896 drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1880
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1881 static void _dpk_information(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy,
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1882 enum rtw89_rf_path path)
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1883 {
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1884 const struct rtw89_chan *chan = rtw89_chan_get(rtwdev, RTW89_SUB_ENTITY_0);
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1885 struct rtw89_dpk_info *dpk = &rtwdev->dpk;
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1886
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1887 u8 kidx = dpk->cur_idx[path];
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1888
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1889 dpk->bp[path][kidx].band = chan->band_type;
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1890 dpk->bp[path][kidx].ch = chan->channel;
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1891 dpk->bp[path][kidx].bw = chan->band_width;
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1892
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1893 rtw89_debug(rtwdev, RTW89_DBG_RFK,
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1894 "[DPK] S%d[%d] (PHY%d): TSSI %s/ DBCC %s/ %s/ CH%d/ %s\n",
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1895 path, dpk->cur_idx[path], phy,
76fb99e9e8468c Ping-Ke Shih 2024-06-21 @1896 rtwdev->is_tssi_mode[path] ? "on" : "off",
76fb99e9e8468c Ping-Ke Shih 2024-06-21 @1897 rtwdev->dbcc_en ? "on" : "off",
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1898 dpk->bp[path][kidx].band == 0 ? "2G" :
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1899 dpk->bp[path][kidx].band == 1 ? "5G" : "6G",
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1900 dpk->bp[path][kidx].ch,
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1901 dpk->bp[path][kidx].bw == 0 ? "20M" :
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1902 dpk->bp[path][kidx].bw == 1 ? "40M" : "80M");
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1903 }
76fb99e9e8468c Ping-Ke Shih 2024-06-21 1904
:::::: The code at line 1896 was first introduced by commit
:::::: 76fb99e9e8468c10e2936d313dfe1e7214c951ef UPSTREAM: wifi: rtw89: 8852bt: rfk: add DPK
:::::: TO: Ping-Ke Shih <pkshih@realtek.com>
:::::: CC: Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-07-28 15:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202507282341.drTGfLWA-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.