From: Arnd Bergmann <arnd@kernel.org>
To: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Cai Huoqing <cai.huoqing@linux.dev>
Cc: Arnd Bergmann <arnd@arndb.de>, Dragan Simic <dsimic@manjaro.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Daniel Golle <daniel@makrotopia.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Christian Marangi <ansuelsmth@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Markus Mayer <mmayer@broadcom.com>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] hwrng: nomadik: add ARM_AMBA dependency
Date: Tue, 29 Jul 2025 17:28:00 +0200 [thread overview]
Message-ID: <20250729152804.2411621-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing this driver is only possible when the AMBA bus driver is
available in the kernel:
x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_remove':
nomadik-rng.c:(.text+0x67): undefined reference to `amba_release_regions'
x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_probe':
nomadik-rng.c:(.text+0xee): undefined reference to `amba_request_regions'
x86_64-linux-ld: nomadik-rng.c:(.text+0x18d): undefined reference to `amba_release_regions'
The was previously implied by the 'depends on ARCH_NOMADIK', but needs to be
specified for the COMPILE_TEST case.
Fixes: d5e93b3374e4 ("hwrng: Kconfig - Add helper dependency on COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/char/hw_random/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 3227dcaa9111..aef4406973f3 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -312,6 +312,7 @@ config HW_RANDOM_INGENIC_TRNG
config HW_RANDOM_NOMADIK
tristate "ST-Ericsson Nomadik Random Number Generator support"
depends on ARCH_NOMADIK || COMPILE_TEST
+ depends on ARM_AMBA
default HW_RANDOM
help
This driver provides kernel-side support for the Random Number
--
2.39.5
next reply other threads:[~2025-07-29 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 15:28 Arnd Bergmann [this message]
2025-08-16 9:34 ` [PATCH] hwrng: nomadik: add ARM_AMBA dependency Herbert Xu
2025-10-06 8:23 ` Geert Uytterhoeven
2025-10-06 9:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729152804.2411621-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=arnd@arndb.de \
--cc=aurelien@aurel32.net \
--cc=cai.huoqing@linux.dev \
--cc=daniel@makrotopia.org \
--cc=dsimic@manjaro.org \
--cc=francesco.dolcini@toradex.com \
--cc=geert+renesas@glider.be \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=mmayer@broadcom.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.