From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE90EC87FCB for ; Wed, 30 Jul 2025 13:45:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7FD75828DA; Wed, 30 Jul 2025 13:45:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wvsY2Iv6ZTYa; Wed, 30 Jul 2025 13:45:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E0F58828F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1753883124; bh=99cxL8htYRt+yGKbu/4cFc974KX5UESL7l+AmDSxrnM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K1sg1pvBpyUIyYNRfjZyxbJES9AV7GN1kNxmFCGbUk1UfGfvm27D2GLFXz6bu5fkH J5+2qiIXv23b6uhyNPIqLTR765Q4fjzxrdBLsiZ2pj1Trgs/Q30Kd9y2lkZ+VxJzEB Z1gMZlHbAhEnF7qAn2U967Md/jrXXD8M804UiJYAWIk+1oJzXkhd6j5U1T6qKZQo22 y5msqB1hX3YPzEP022v5iWJxE30TLT4IhgxpEaxEKC+PFAZFCcDoGCmsutmrWjRlN4 MYiZHQAcz2J3tzmR2K8fx/gSiNR4X+2n8e44B9ZDdcf5AcfxIPHOYHAqvkJwZGYBqc ppC4S1Mt7sAxA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id E0F58828F7; Wed, 30 Jul 2025 13:45:24 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 0F804186 for ; Wed, 30 Jul 2025 13:45:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 00E7F4080A for ; Wed, 30 Jul 2025 13:45:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yUTpc64Gwwy7 for ; Wed, 30 Jul 2025 13:45:22 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5DF9640763 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5DF9640763 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5DF9640763 for ; Wed, 30 Jul 2025 13:45:22 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D083D6113A; Wed, 30 Jul 2025 13:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31CABC4CEE7; Wed, 30 Jul 2025 13:45:20 +0000 (UTC) Date: Wed, 30 Jul 2025 06:45:19 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Vadim Fedorenko , Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Paolo Abeni , Simon Horman , netdev@vger.kernel.org Message-ID: <20250730064519.38abc0c3@kernel.org> In-Reply-To: <15ca2392-1dbd-4f4d-a478-3d8edc32bc90@linux.dev> References: <20250729102354.771859-1-vadfed@meta.com> <20250729184529.149be2c3@kernel.org> <15ca2392-1dbd-4f4d-a478-3d8edc32bc90@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753883120; bh=13ObknUHmABT+w8CaNxwkbPmI3GtDczqQN2CCJN7YjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t83Oy5sCfDdc9Dduz4fVHZN9v1uyS2a+9XcuIuewQvegVOzJdk+irdN3AUcz5Am9z zcHu1jDHNd7QyOGcsNFtj+VfnaHI5rh+I0SjxHTIu+r1axAcnO1ajZVwn8lVzmjUER yu7WfvFObbDxkmtAmdOY54SA795arO5Ve9PkAoprKsHq68x2oGiKM1omVFXJpTm+av VTBpK1dojJ7YLSsGxUS88pqr+KlUpYP4wg3hxqMNVV0ibzBKxMnNucwF5KSJKpMAnA C3KKSawsl3j2EATteo0JYdCS6JoXt4VfRHleaJnfks3nzW6VroXzBbBfS2ZdDzjWEZ lcvaQ2jKwEQpQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=t83Oy5sC Subject: Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 30 Jul 2025 10:22:36 +0100 Vadim Fedorenko wrote: > >> + name: fec-hist > >> + subset-of: fec-stat =20 > >=20 > > no need to make this a subset, better to make it its own attr set =20 >=20 > like a set for general histogram? or still fec-specific? You can make it a general histogram, I guess =F0=9F=A4=94=EF=B8=8F No strong preference. > >> + attributes: > >> + - > >> + name: fec-hist-bin-low > >> + - > >> + name: fec-hist-bin-high > >> + - > >> + name: fec-hist-bin-val > >> - > >> name: fec > >> attr-cnt-name: __ethtool-a-fec-cnt =20 > > =20 > >> +static const struct ethtool_fec_hist_range netdevsim_fec_ranges[] =3D= { > >> + { 0, 0}, > >> + { 1, 3}, > >> + { 4, 7}, > >> + { -1, -1} > >> +}; =20 > >=20 > > Let's add a define for the terminating element? =20 >=20 > I believe it's about (-1, -1) case. If we end up using (0, 0) then there > is no need to define anything, right? Yup, 0,0 is better written as {} so no need for a define. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177D5293B73 for ; Wed, 30 Jul 2025 13:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753883121; cv=none; b=CtsUswD5GttPFeWnp7zuAoI/oNKpUbLcLoVq9erg5XNG+42l4mbl+EPiEc6SsOH2IhrQS1HNMxPz0LQLUxXYmkpjIhwkAm9JKt5v08xCKeiY+10nIG/X84kqpGm5vVrDKNb+lI/FDkMkZgiDEIotKEIUG/biHAD0enUKX1wWZtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753883121; c=relaxed/simple; bh=13ObknUHmABT+w8CaNxwkbPmI3GtDczqQN2CCJN7YjM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EGs8z2/L075HAue68xBCZrTv2d6h7GGQ5zpDuRW4WRMZ/sJFHJSH7OaALw1ujJL6wp6jZ1qup31PRRFkoalAaAltEWwcH4bWxrEaoha/hsj7vRagnQR+tTBlhvYIt30HYSYm/MgeJXjgRjw8T/PcGbrhdtSNQFtsvL5x8bnX0Ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t83Oy5sC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t83Oy5sC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31CABC4CEE7; Wed, 30 Jul 2025 13:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753883120; bh=13ObknUHmABT+w8CaNxwkbPmI3GtDczqQN2CCJN7YjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t83Oy5sCfDdc9Dduz4fVHZN9v1uyS2a+9XcuIuewQvegVOzJdk+irdN3AUcz5Am9z zcHu1jDHNd7QyOGcsNFtj+VfnaHI5rh+I0SjxHTIu+r1axAcnO1ajZVwn8lVzmjUER yu7WfvFObbDxkmtAmdOY54SA795arO5Ve9PkAoprKsHq68x2oGiKM1omVFXJpTm+av VTBpK1dojJ7YLSsGxUS88pqr+KlUpYP4wg3hxqMNVV0ibzBKxMnNucwF5KSJKpMAnA C3KKSawsl3j2EATteo0JYdCS6JoXt4VfRHleaJnfks3nzW6VroXzBbBfS2ZdDzjWEZ lcvaQ2jKwEQpQ== Date: Wed, 30 Jul 2025 06:45:19 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Vadim Fedorenko , Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Paolo Abeni , Simon Horman , netdev@vger.kernel.org Subject: Re: [RFC PATCH] ethtool: add FEC bins histogramm report Message-ID: <20250730064519.38abc0c3@kernel.org> In-Reply-To: <15ca2392-1dbd-4f4d-a478-3d8edc32bc90@linux.dev> References: <20250729102354.771859-1-vadfed@meta.com> <20250729184529.149be2c3@kernel.org> <15ca2392-1dbd-4f4d-a478-3d8edc32bc90@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 30 Jul 2025 10:22:36 +0100 Vadim Fedorenko wrote: > >> + name: fec-hist > >> + subset-of: fec-stat =20 > >=20 > > no need to make this a subset, better to make it its own attr set =20 >=20 > like a set for general histogram? or still fec-specific? You can make it a general histogram, I guess =F0=9F=A4=94=EF=B8=8F No strong preference. > >> + attributes: > >> + - > >> + name: fec-hist-bin-low > >> + - > >> + name: fec-hist-bin-high > >> + - > >> + name: fec-hist-bin-val > >> - > >> name: fec > >> attr-cnt-name: __ethtool-a-fec-cnt =20 > > =20 > >> +static const struct ethtool_fec_hist_range netdevsim_fec_ranges[] =3D= { > >> + { 0, 0}, > >> + { 1, 3}, > >> + { 4, 7}, > >> + { -1, -1} > >> +}; =20 > >=20 > > Let's add a define for the terminating element? =20 >=20 > I believe it's about (-1, -1) case. If we end up using (0, 0) then there > is no need to define anything, right? Yup, 0,0 is better written as {} so no need for a define.