From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [6.17-rc0 regression] WARNING: CPU: 15 PID: 321705 at fs/xfs/xfs_trans.c:256 xfs_trans_alloc+0x19b/0x280
Date: Wed, 30 Jul 2025 16:12:06 +0200 [thread overview]
Message-ID: <20250730141206.GA11784@lst.de> (raw)
In-Reply-To: <aImAfw5TLefSY9Ha@dread.disaster.area>
On Wed, Jul 30, 2025 at 12:16:31PM +1000, Dave Chinner wrote:
> Christoph, looks like this is one for you - these transactions
> previously got caught in sb_start_intwrite() before the freeze state
> warning check (i.e. modifications get blocked once freeze starts, so
> never get to the warning whilst the fs is frozen). The new code
> checks the freeze state and emits the warning before the transaction
> can (correctly) account/block on freeze state via
> sb_start_intwrite().
Yeah, the WARN_ON should move down. I'll prepare a patch.
next prev parent reply other threads:[~2025-07-30 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4Pdlams-6A6GKExDCiB0UCMs05wgppYESFHPkiWWLomRD-zUJABHPKzUijI8wpMOGqJUEgmdH-CGMHWXzl-2Lg==@protonmail.internalid>
2025-07-30 2:16 ` [6.17-rc0 regression] WARNING: CPU: 15 PID: 321705 at fs/xfs/xfs_trans.c:256 xfs_trans_alloc+0x19b/0x280 Dave Chinner
2025-07-30 14:12 ` Christoph Hellwig [this message]
2025-07-30 15:16 ` [ " Carlos Maiolino
2025-07-30 15:24 ` Darrick J. Wong
2025-07-30 15:35 ` Carlos Maiolino
2025-07-30 16:08 ` Darrick J. Wong
2025-07-30 16:37 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730141206.GA11784@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.