From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
Simon Horman <horms@kernel.org>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [RFC net-next v1 1/1] e1000e: Introduce private flag and module param to disable K1
Date: Wed, 30 Jul 2025 17:06:41 -0700 [thread overview]
Message-ID: <20250730170641.208bbce5@kernel.org> (raw)
In-Reply-To: <55570ac6-8cd7-4a00-804e-7164f374f8ae@intel.com>
On Wed, 30 Jul 2025 15:10:45 -0700 Jacob Keller wrote:
> > FWIW I will still object. The ethtool priv flag is fine, personally
> > I don't have a strong preference on devlink vs ethtool priv flags.
> > But if you a module param you'd need a very strong justification..
>
> I think just the ethtool private flag is sufficient. The primary
> downside appears to be the "inability" to easily set the flag at boot,
> but...
I haven't played with udev in a while but it used to have the ability
to run a command / script when device appears. So that'd be my first
choice if how to hook the setting in when device is probed.
next prev parent reply other threads:[~2025-07-31 0:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 9:24 [RFC net-next v1 1/1] e1000e: Introduce private flag and module param to disable K1 Vitaly Lifshits
2025-07-14 16:55 ` Simon Horman
2025-07-14 21:30 ` Keller, Jacob E
2025-07-16 10:25 ` Ruinskiy, Dima
2025-07-30 14:11 ` Lifshits, Vitaly
2025-07-30 15:28 ` Simon Horman
2025-07-30 20:42 ` Jakub Kicinski
2025-07-30 22:10 ` Jacob Keller
2025-07-31 0:06 ` Jakub Kicinski [this message]
2025-07-31 7:00 ` Ruinskiy, Dima
2025-07-31 14:19 ` Jakub Kicinski
2025-07-31 15:51 ` Jacob Keller
2025-08-03 12:38 ` Lifshits, Vitaly
2025-08-28 7:15 ` En-Wei WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730170641.208bbce5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.