Re: [Buildroot] [PATCH 4/4] package/compliance-as-code: add new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Wed, 30 Jul 2025 20:09:11 +0200
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:

> Thanks for the pointer, I was not aware of those integrated tests. I'll
> take a look at it and add some (without knowing yet the full scope of this
> framework, I guess it would be nice to get at least a matrix of tests on
> the different Kconfig options added for this package)

You don't have to test all possible combinations. Just a single test
that exercises a bit compliance-as-code + openscap would be more than
enough.

> > I assume you verified all those host dependencies are actually needed?  
> 
> Yes. For all the packages added in this series, I started by performing a
> native build in a minimal container, to distinguish the mandatory
> dependencies from the optional ones. So this list really reflects the
> minimal set of needed deps.

Excellent!

> Ah, good catch ! I accidentally got rid of a block here when reworking this
> part. That should rather be:
> 
> ifeq($(BR2_PACKAGE_COMPLIANCE_AS_CODE_DATASTREAM_ONLY),y)
> COMPLIANCE_AS_CODE_MAKE_OPTS = -d
> endif
> 
> COMPLIANCE_AS_CODE_MAKE_OPTS += \
> 	$(foreach p,\
> 	$(call qstrip,$(BR2_PACKAGE_COMPLIANCE_AS_CODE_PRODUCTS)),\
> 	$(if $(BR2_PACKAGE_COMPLIANCE_AS_CODE_DATASTREAM_ONLY), generate-ssg-$(p)-ds.xml, $(p)))
> 
> (and so, += instead of = when evaluating the products string)

Sounds good. Perhaps you want to indent this a bit:

COMPLIANCE_AS_CODE_MAKE_OPTS += \
 	$(foreach p,\
 		$(call qstrip,$(BR2_PACKAGE_COMPLIANCE_AS_CODE_PRODUCTS)),\
 		$(if $(BR2_PACKAGE_COMPLIANCE_AS_CODE_DATASTREAM_ONLY), generate-ssg-$(p)-ds.xml, $(p))
	)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot