All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Srinivas Kandagatla" <srini@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot env layout
Date: Wed, 30 Jul 2025 18:52:14 -0500	[thread overview]
Message-ID: <20250730235214.GA1907865-robh@kernel.org> (raw)
In-Reply-To: <OSBPR01MB16702D6947772E526F64D63CBC24A@OSBPR01MB1670.jpnprd01.prod.outlook.com>

On Wed, Jul 30, 2025 at 09:17:47PM +0800, Shiji Yang wrote:
> This newly introduced property allows users to declare the size of
> the environment storage area.

Why do you need it to be less than the partition size? They commit msg 
needs to explain that.

The partition size for fixed partitions in particular are purely a DT 
construct. No reason the partition size can't always be the env size.

> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> ---
>  .../devicetree/bindings/nvmem/layouts/u-boot,env.yaml      | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> index 56a8f55d4..e0b65a53e 100644
> --- a/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> @@ -46,6 +46,12 @@ properties:
>      type: object
>      description: Command to use for automatic booting
>  
> +  env-size:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Size of the environment storage area in bytes. If this property
> +      is not defined, the default size is the partition size.
> +
>    ethaddr:
>      type: object
>      description: Ethernet interfaces base MAC address.
> @@ -85,6 +91,7 @@ examples:
>          env: partition@40000 {
>              compatible = "u-boot,env";
>              reg = <0x40000 0x10000>;
> +            env-size = <0x1000>;
>  
>              mac: ethaddr {
>                  #nvmem-cell-cells = <1>;
> -- 
> 2.50.0
> 

  parent reply	other threads:[~2025-07-30 23:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 13:17 [PATCH 1/2] nvmem: u-boot-env: support specifying the env storage size Shiji Yang
2025-07-30 13:17 ` [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot env layout Shiji Yang
2025-07-30 13:20   ` Krzysztof Kozlowski
2025-07-30 23:52   ` Rob Herring [this message]
2025-07-31  8:33     ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250730235214.GA1907865-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=srini@kernel.org \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.