From: Lance Yang <lance.yang@linux.dev>
To: lkp@intel.com, akpm@linux-foundation.org
Cc: zi.li@linux.dev, llvm@lists.linux.dev, mhiramat@kernel.org,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Lance Yang <lance.yang@linux.dev>
Subject: [PATCH 1/1] hung_task: fix objtool sibling call warning in watchdog()
Date: Thu, 31 Jul 2025 10:39:34 +0800 [thread overview]
Message-ID: <20250731023934.48840-1-lance.yang@linux.dev> (raw)
From: Lance Yang <lance.yang@linux.dev>
The kernel test robot reported an objtool warning on the loongarch
architecture with clang:
vmlinux.o: warning: objtool: watchdog+0x418: sibling call from
callable instruction with modified stack frame
To resolve this, explicitly prevent the compiler from inlining or
performing a tail call on check_hung_uninterruptible_tasks() by marking
it with the noinline attribute. This ensures a standard function call
with a proper stack frame, satisfying objtool's validation requirements.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507301256.cZlxQ10s-lkp@intel.com/
Signed-off-by: Lance Yang <lance.yang@linux.dev>
---
kernel/hung_task.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 8708a1205f82..a5b5a0a2c262 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -283,7 +283,7 @@ static bool rcu_lock_break(struct task_struct *g, struct task_struct *t)
* a really long time (120 seconds). If that happens, print out
* a warning.
*/
-static void check_hung_uninterruptible_tasks(unsigned long timeout)
+static noinline void check_hung_uninterruptible_tasks(unsigned long timeout)
{
int max_count = sysctl_hung_task_check_count;
unsigned long last_break = jiffies;
--
2.49.0
next reply other threads:[~2025-07-31 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 2:39 Lance Yang [this message]
2025-07-31 17:59 ` [PATCH 1/1] hung_task: fix objtool sibling call warning in watchdog() Nathan Chancellor
2025-08-01 1:29 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731023934.48840-1-lance.yang@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=zi.li@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.