From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EC991DE8A8; Thu, 31 Jul 2025 17:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753981548; cv=none; b=XPZQXVKqzxxm0cKZRz+oGZ/8413KNN0ZsLsuaoZX3SKlZ3Wl2P+moBhKS8cjTfgrv+jmYCY8FA6sklRqezGajkPuRIrnu1R3rrjjpfWCifJa+97s75l925hBUIyoC4g50d8zrr3Kag5oyEuty+PULI5BCNBtrRPV4pg/J1wMCwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753981548; c=relaxed/simple; bh=cygdeMZgK8iW3+xuI2Q01zkcGjAmxwn4nIdnViALepc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tZyIcWKnBUqXTqeQKca8D7WnEWOPNaJxpEzMq6ODgPQNqUyMnq3/TrX2lSvXOZY3Srk97ql4AqyyLieEVKzIWIPmZ0JZz3vpxrgBvkOjDEYlf+Et2Yy8A6fvXAlUltnWUhhGLuUoQrMWIndc2Ql5TF0MBuqUyZTP5QTKpzZ1eM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G0ZCTUEK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G0ZCTUEK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09D6BC4CEEF; Thu, 31 Jul 2025 17:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753981548; bh=cygdeMZgK8iW3+xuI2Q01zkcGjAmxwn4nIdnViALepc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G0ZCTUEKD9dun9DBxQYzx4GHq2lIpW/KDI9pFeE32zJIBNpUzP/FFvrdecrjwQf84 Snz90sAhbikpsX3fCAvtqQoNR3Yl8YuLiqUxPCciFpUuiRnX08tO6sxyKF7IpEYKay f3yvKnhu01DA9k4hwPs81dSCklqesFppVvmDhkQAKiugR48zYm890ZcmMWfHmLW+NS VnJc2mvnvy986vxxBto1dpRoyZH7KTIYtRUSqgVcoU6RknqiBrdTIanBJb7FM5aYIq OLyH7s5ANotGLlkRTto+hjErAZ07bXo2z5GGSRUYFjEfgGYMosqxpw43tMZzhRXjjI 0NwDzzdyIGzhA== Date: Thu, 31 Jul 2025 10:05:47 -0700 From: Kees Cook To: Simon Horman Cc: Alexander Lobakin , intel-wired-lan@lists.osuosl.org, Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , nxne.cnse.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH iwl-next v3 16/18] idpf: add support for XDP on Rx Message-ID: <202507310955.03E47CFA4@keescook> References: <20250730160717.28976-1-aleksander.lobakin@intel.com> <20250730160717.28976-17-aleksander.lobakin@intel.com> <20250731123734.GA8494@horms.kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250731123734.GA8494@horms.kernel.org> On Thu, Jul 31, 2025 at 01:37:34PM +0100, Simon Horman wrote: > While I appreciate the desire for improved performance and nicer code > generation. I think the idea of writing 64 bits of data to the > address of a 32 bit member of a structure goes against the direction > of hardening work by Kees and others. Agreed: it's better to avoid obscuring these details from the compiler so it can have an "actual" view of the object sizes involved. > Indeed, it seems to me this is the kind of thing that struct_group() > aims to avoid. > > In this case struct group() doesn't seem like the best option, > because it would provide a 64-bit buffer that we can memcpy into. > But it seems altogether better to simply assign u64 value to a u64 member. Agreed: with struct_group you get a sized pointer, and while you can provide a struct tag to make it an assignable object, it doesn't make too much sense here. > So I'm wondering if an approach along the following lines is appropriate > (Very lightly compile tested only!). > > And yes, there is room for improvement of the wording of the comment > I included below. > > diff --git a/include/net/libeth/xdp.h b/include/net/libeth/xdp.h > index f4880b50e804..a7d3d8e44aa6 100644 > --- a/include/net/libeth/xdp.h > +++ b/include/net/libeth/xdp.h > @@ -1283,11 +1283,7 @@ static inline void libeth_xdp_prepare_buff(struct libeth_xdp_buff *xdp, > const struct page *page = __netmem_to_page(fqe->netmem); > > #ifdef __LIBETH_WORD_ACCESS > - static_assert(offsetofend(typeof(xdp->base), flags) - > - offsetof(typeof(xdp->base), frame_sz) == > - sizeof(u64)); > - > - *(u64 *)&xdp->base.frame_sz = fqe->truesize; > + xdp->base.frame_sz_le_qword = fqe->truesize; > #else > xdp_init_buff(&xdp->base, fqe->truesize, xdp->base.rxq); > #endif > diff --git a/include/net/xdp.h b/include/net/xdp.h > index b40f1f96cb11..b5eedeb82c9b 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -85,8 +85,19 @@ struct xdp_buff { > void *data_hard_start; > struct xdp_rxq_info *rxq; > struct xdp_txq_info *txq; > - u32 frame_sz; /* frame size to deduce data_hard_end/reserved tailroom*/ > - u32 flags; /* supported values defined in xdp_buff_flags */ > + union { > + /* Allow setting frame_sz and flags as a single u64 on > + * little endian systems. This may may give optimal > + * performance. */ > + u64 frame_sz_le_qword; > + struct { > + /* Frame size to deduce data_hard_end/reserved > + * tailroom. */ > + u32 frame_sz; > + /* Supported values defined in xdp_buff_flags. */ > + u32 flags; > + }; > + }; > }; Yeah, this looks like a nice way to express this, and is way more descriptive than "(u64 *)&xdp->base.frame_sz" :) -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACCDAC87FCC for ; Thu, 31 Jul 2025 17:05:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7B67E82925; Thu, 31 Jul 2025 17:05:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VKxBkKRbpYOY; Thu, 31 Jul 2025 17:05:52 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7638A846AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1753981552; bh=pSV6VWntSX18EcrIQyqgacZTaSkFwaiwlgpBWxGCe+U=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bGtASvXC9Xz6As+wLdR9/2bv8xkdxWsQXVK2GM1d0mA8nfJ+7v8TeBZlMBjxS12SU 2UrfgDUzW0pb1b48CoFYkNH6Hb4Cq4Ma3rcTeN5s60UQ4AIi9bwnX9KhaDDTNUsJNE 5NOD4AE93kbsaKQesao6whDgf3POw+uEuqbfY9BKkQmi98znmir714fT8hD7qOSooz BM2iBAQZSK1r2rkDdmdApKX4FYaFuFVGPWjoJ8ateBtujciLbPZAJKRfminWeBiUtx Te2Tk7HNx5L/HMG/SILi+8VaW0n+Yn3VHSjgimm9JNdN/lpImJX9xbOWjNj96MwALi obZMT/ojbCHOg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 7638A846AB; Thu, 31 Jul 2025 17:05:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id A3CCC168 for ; Thu, 31 Jul 2025 17:05:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 95D0B6141D for ; Thu, 31 Jul 2025 17:05:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4TBvrYLvU2x6 for ; Thu, 31 Jul 2025 17:05:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kees@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org DD47B60B8B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DD47B60B8B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id DD47B60B8B for ; Thu, 31 Jul 2025 17:05:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 721D1A55566; Thu, 31 Jul 2025 17:05:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09D6BC4CEEF; Thu, 31 Jul 2025 17:05:48 +0000 (UTC) Date: Thu, 31 Jul 2025 10:05:47 -0700 From: Kees Cook To: Simon Horman Cc: Alexander Lobakin , intel-wired-lan@lists.osuosl.org, Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , nxne.cnse.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Message-ID: <202507310955.03E47CFA4@keescook> References: <20250730160717.28976-1-aleksander.lobakin@intel.com> <20250730160717.28976-17-aleksander.lobakin@intel.com> <20250731123734.GA8494@horms.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250731123734.GA8494@horms.kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753981548; bh=cygdeMZgK8iW3+xuI2Q01zkcGjAmxwn4nIdnViALepc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G0ZCTUEKD9dun9DBxQYzx4GHq2lIpW/KDI9pFeE32zJIBNpUzP/FFvrdecrjwQf84 Snz90sAhbikpsX3fCAvtqQoNR3Yl8YuLiqUxPCciFpUuiRnX08tO6sxyKF7IpEYKay f3yvKnhu01DA9k4hwPs81dSCklqesFppVvmDhkQAKiugR48zYm890ZcmMWfHmLW+NS VnJc2mvnvy986vxxBto1dpRoyZH7KTIYtRUSqgVcoU6RknqiBrdTIanBJb7FM5aYIq OLyH7s5ANotGLlkRTto+hjErAZ07bXo2z5GGSRUYFjEfgGYMosqxpw43tMZzhRXjjI 0NwDzzdyIGzhA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=G0ZCTUEK Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 16/18] idpf: add support for XDP on Rx X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jul 31, 2025 at 01:37:34PM +0100, Simon Horman wrote: > While I appreciate the desire for improved performance and nicer code > generation. I think the idea of writing 64 bits of data to the > address of a 32 bit member of a structure goes against the direction > of hardening work by Kees and others. Agreed: it's better to avoid obscuring these details from the compiler so it can have an "actual" view of the object sizes involved. > Indeed, it seems to me this is the kind of thing that struct_group() > aims to avoid. > > In this case struct group() doesn't seem like the best option, > because it would provide a 64-bit buffer that we can memcpy into. > But it seems altogether better to simply assign u64 value to a u64 member. Agreed: with struct_group you get a sized pointer, and while you can provide a struct tag to make it an assignable object, it doesn't make too much sense here. > So I'm wondering if an approach along the following lines is appropriate > (Very lightly compile tested only!). > > And yes, there is room for improvement of the wording of the comment > I included below. > > diff --git a/include/net/libeth/xdp.h b/include/net/libeth/xdp.h > index f4880b50e804..a7d3d8e44aa6 100644 > --- a/include/net/libeth/xdp.h > +++ b/include/net/libeth/xdp.h > @@ -1283,11 +1283,7 @@ static inline void libeth_xdp_prepare_buff(struct libeth_xdp_buff *xdp, > const struct page *page = __netmem_to_page(fqe->netmem); > > #ifdef __LIBETH_WORD_ACCESS > - static_assert(offsetofend(typeof(xdp->base), flags) - > - offsetof(typeof(xdp->base), frame_sz) == > - sizeof(u64)); > - > - *(u64 *)&xdp->base.frame_sz = fqe->truesize; > + xdp->base.frame_sz_le_qword = fqe->truesize; > #else > xdp_init_buff(&xdp->base, fqe->truesize, xdp->base.rxq); > #endif > diff --git a/include/net/xdp.h b/include/net/xdp.h > index b40f1f96cb11..b5eedeb82c9b 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -85,8 +85,19 @@ struct xdp_buff { > void *data_hard_start; > struct xdp_rxq_info *rxq; > struct xdp_txq_info *txq; > - u32 frame_sz; /* frame size to deduce data_hard_end/reserved tailroom*/ > - u32 flags; /* supported values defined in xdp_buff_flags */ > + union { > + /* Allow setting frame_sz and flags as a single u64 on > + * little endian systems. This may may give optimal > + * performance. */ > + u64 frame_sz_le_qword; > + struct { > + /* Frame size to deduce data_hard_end/reserved > + * tailroom. */ > + u32 frame_sz; > + /* Supported values defined in xdp_buff_flags. */ > + u32 flags; > + }; > + }; > }; Yeah, this looks like a nice way to express this, and is way more descriptive than "(u64 *)&xdp->base.frame_sz" :) -- Kees Cook