Re: [PATCH net-next v10 01/15] dt-bindings: net: Introduce the ethernet-connector description

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hello Andrew,

First, thanks a lot for taking a look a this series !

On Sat, 26 Jul 2025 21:49:07 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> >  - The number of lanes, which is a quite generic property that allows
> >    differentating between multiple similar technologies such as BaseT1
> >    and "regular" BaseT (which usually means BaseT4).  
> 
> > +            mdi {
> > +                connector-0 {
> > +                    lanes = <2>;
> > +                    media = "BaseT";  
> 
> This is correct when the port is Fast Ethernet. However, as you point
> out, now a days, the more normal case is 1G, with 4 lanes for BaseT.
> To avoid developers just copy/pasting without engaging brain, maybe
> add a comment about it being a Fast Ethernet port?

Absolutely :)

Maxime

> 
> 	Andrew