From: kernel test robot <lkp@intel.com>
To: Jakub Sitnicki <jakub@cloudflare.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Arthur Fabre" <arthur@arthurfabre.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jesse Brandeburg" <jbrandeburg@cloudflare.com>,
"Joanne Koong" <joannelkoong@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Toke Høiland-Jørgensen" <thoiland@redhat.com>,
"Yan Zhai" <yan@cloudflare.com>,
kernel-team@cloudflare.com, netdev@vger.kernel.org,
"Stanislav Fomichev" <sdf@fomichev.me>
Subject: Re: [PATCH bpf-next v5 2/9] bpf: Enable read/write access to skb metadata through a dynptr
Date: Fri, 1 Aug 2025 06:18:00 +0800 [thread overview]
Message-ID: <202508010501.YGP8iOar-lkp@intel.com> (raw)
In-Reply-To: <20250731-skb-metadata-thru-dynptr-v5-2-f02f6b5688dc@cloudflare.com>
Hi Jakub,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Sitnicki/bpf-Add-dynptr-type-for-skb-metadata/20250731-183157
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20250731-skb-metadata-thru-dynptr-v5-2-f02f6b5688dc%40cloudflare.com
patch subject: [PATCH bpf-next v5 2/9] bpf: Enable read/write access to skb metadata through a dynptr
config: i386-buildonly-randconfig-005-20250801 (https://download.01.org/0day-ci/archive/20250801/202508010501.YGP8iOar-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250801/202508010501.YGP8iOar-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508010501.YGP8iOar-lkp@intel.com/
All warnings (new ones prefixed by >>):
kernel/bpf/helpers.c: In function '____bpf_snprintf':
kernel/bpf/helpers.c:1069:9: warning: function '____bpf_snprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1069 | err = bstr_printf(str, str_size, fmt, data.bin_args);
| ^~~
In file included from include/linux/string.h:382,
from arch/x86/include/asm/page_32.h:18,
from arch/x86/include/asm/page.h:14,
from arch/x86/include/asm/processor.h:20,
from arch/x86/include/asm/timex.h:5,
from include/linux/timex.h:67,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/jiffies.h:10,
from include/linux/ktime.h:25,
from include/linux/timer.h:6,
from include/linux/workqueue.h:9,
from include/linux/bpf.h:10,
from kernel/bpf/helpers.c:4:
kernel/bpf/helpers.c: In function '__bpf_dynptr_read':
>> include/linux/fortify-string.h:115:33: warning: argument 2 null where non-null expected [-Wnonnull]
115 | #define __underlying_memmove __builtin_memmove
| ^
include/linux/fortify-string.h:645:9: note: in expansion of macro '__underlying_memmove'
645 | __underlying_##op(p, q, __copy_size); \
| ^~~~~~~~~~~~~
include/linux/fortify-string.h:694:27: note: in expansion of macro '__fortify_memcpy_chk'
694 | #define memmove(p, q, s) __fortify_memcpy_chk(p, q, s, \
| ^~~~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1784:17: note: in expansion of macro 'memmove'
1784 | memmove(dst, bpf_skb_meta_pointer(src->data, src->offset + offset), len);
| ^~~~~~~
include/linux/fortify-string.h:115:33: note: in a call to built-in function '__builtin_memmove'
115 | #define __underlying_memmove __builtin_memmove
| ^
include/linux/fortify-string.h:645:9: note: in expansion of macro '__underlying_memmove'
645 | __underlying_##op(p, q, __copy_size); \
| ^~~~~~~~~~~~~
include/linux/fortify-string.h:694:27: note: in expansion of macro '__fortify_memcpy_chk'
694 | #define memmove(p, q, s) __fortify_memcpy_chk(p, q, s, \
| ^~~~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1784:17: note: in expansion of macro 'memmove'
1784 | memmove(dst, bpf_skb_meta_pointer(src->data, src->offset + offset), len);
| ^~~~~~~
kernel/bpf/helpers.c: In function '__bpf_dynptr_write':
include/linux/fortify-string.h:115:33: warning: argument 1 null where non-null expected [-Wnonnull]
115 | #define __underlying_memmove __builtin_memmove
| ^
include/linux/fortify-string.h:645:9: note: in expansion of macro '__underlying_memmove'
645 | __underlying_##op(p, q, __copy_size); \
| ^~~~~~~~~~~~~
include/linux/fortify-string.h:694:27: note: in expansion of macro '__fortify_memcpy_chk'
694 | #define memmove(p, q, s) __fortify_memcpy_chk(p, q, s, \
| ^~~~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1845:17: note: in expansion of macro 'memmove'
1845 | memmove(bpf_skb_meta_pointer(dst->data, dst->offset + offset), src, len);
| ^~~~~~~
include/linux/fortify-string.h:115:33: note: in a call to built-in function '__builtin_memmove'
115 | #define __underlying_memmove __builtin_memmove
| ^
include/linux/fortify-string.h:645:9: note: in expansion of macro '__underlying_memmove'
645 | __underlying_##op(p, q, __copy_size); \
| ^~~~~~~~~~~~~
include/linux/fortify-string.h:694:27: note: in expansion of macro '__fortify_memcpy_chk'
694 | #define memmove(p, q, s) __fortify_memcpy_chk(p, q, s, \
| ^~~~~~~~~~~~~~~~~~~~
kernel/bpf/helpers.c:1845:17: note: in expansion of macro 'memmove'
1845 | memmove(bpf_skb_meta_pointer(dst->data, dst->offset + offset), src, len);
| ^~~~~~~
vim +115 include/linux/fortify-string.h
78a498c3a227f2 Alexander Potapenko 2022-10-24 103
78a498c3a227f2 Alexander Potapenko 2022-10-24 104 #if defined(__SANITIZE_MEMORY__)
78a498c3a227f2 Alexander Potapenko 2022-10-24 105 /*
78a498c3a227f2 Alexander Potapenko 2022-10-24 106 * For KMSAN builds all memcpy/memset/memmove calls should be replaced by the
78a498c3a227f2 Alexander Potapenko 2022-10-24 107 * corresponding __msan_XXX functions.
78a498c3a227f2 Alexander Potapenko 2022-10-24 108 */
78a498c3a227f2 Alexander Potapenko 2022-10-24 109 #include <linux/kmsan_string.h>
78a498c3a227f2 Alexander Potapenko 2022-10-24 110 #define __underlying_memcpy __msan_memcpy
78a498c3a227f2 Alexander Potapenko 2022-10-24 111 #define __underlying_memmove __msan_memmove
78a498c3a227f2 Alexander Potapenko 2022-10-24 112 #define __underlying_memset __msan_memset
78a498c3a227f2 Alexander Potapenko 2022-10-24 113 #else
a28a6e860c6cf2 Francis Laniel 2021-02-25 114 #define __underlying_memcpy __builtin_memcpy
a28a6e860c6cf2 Francis Laniel 2021-02-25 @115 #define __underlying_memmove __builtin_memmove
a28a6e860c6cf2 Francis Laniel 2021-02-25 116 #define __underlying_memset __builtin_memset
78a498c3a227f2 Alexander Potapenko 2022-10-24 117 #endif
78a498c3a227f2 Alexander Potapenko 2022-10-24 118
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-07-31 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 10:28 [PATCH bpf-next v5 0/9] Add a dynptr type for skb metadata for TC BPF Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 1/9] bpf: Add dynptr type for skb metadata Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 2/9] bpf: Enable read/write access to skb metadata through a dynptr Jakub Sitnicki
2025-07-31 22:18 ` kernel test robot [this message]
2025-07-31 10:28 ` [PATCH bpf-next v5 3/9] selftests/bpf: Cover verifier checks for skb_meta dynptr type Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 4/9] selftests/bpf: Pass just bpf_map to xdp_context_test helper Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 5/9] selftests/bpf: Parametrize test_xdp_context_tuntap Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 6/9] selftests/bpf: Cover read access to skb metadata via dynptr Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 7/9] selftests/bpf: Cover write " Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 8/9] selftests/bpf: Cover read/write to skb metadata at an offset Jakub Sitnicki
2025-07-31 10:28 ` [PATCH bpf-next v5 9/9] selftests/bpf: Cover metadata access from a modified skb clone Jakub Sitnicki
2025-07-31 11:28 ` [PATCH bpf-next v5 0/9] Add a dynptr type for skb metadata for TC BPF Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508010501.YGP8iOar-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=arthur@arthurfabre.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jakub@cloudflare.com \
--cc=jbrandeburg@cloudflare.com \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sdf@fomichev.me \
--cc=thoiland@redhat.com \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.