From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/3] net: hibmcge: fix the np_link_fai error reporting issue
Date: Fri, 1 Aug 2025 11:20:58 +0100 [thread overview]
Message-ID: <20250801102058.GL8494@horms.kernel.org> (raw)
In-Reply-To: <20250731134749.4090041-4-shaojijie@huawei.com>
On Thu, Jul 31, 2025 at 09:47:49PM +0800, Jijie Shao wrote:
> Currently, after modifying device port mode, the np_link_ok state
> is immediately checked. At this point, the device may not yet ready,
> leading to the querying of an intermediate state.
>
> This patch will poll to check if np_link is ok after
> modifying device port mode, and only report np_link_fail upon timeout.
>
> Fixes: e0306637e85d ("net: hibmcge: Add support for mac link exception handling feature")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-08-01 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 13:47 [PATCH net 0/3] There are some bugfix for hibmcge ethernet driver Jijie Shao
2025-07-31 13:47 ` [PATCH net 1/3] net: hibmcge: fix rtnl deadlock issue Jijie Shao
2025-08-01 10:05 ` Simon Horman
2025-08-01 10:44 ` Jijie Shao
2025-08-01 11:05 ` Simon Horman
2025-07-31 13:47 ` [PATCH net 2/3] net: hibmcge: fix the division by zero issue Jijie Shao
2025-08-01 10:11 ` Simon Horman
2025-08-01 10:46 ` Jijie Shao
2025-07-31 13:47 ` [PATCH net 3/3] net: hibmcge: fix the np_link_fai error reporting issue Jijie Shao
2025-08-01 10:20 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801102058.GL8494@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.